Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: catch exception within getFun() #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waitingsong
Copy link
Member

@waitingsong waitingsong commented Dec 21, 2020

for exceptions from Line:4-9 of cliFun() by bin/cli.js of @midwayjs/cli

ref: https://github.com/midwayjs/cli/blob/master/packages/cli/bin/cli.js#L4-L9

ref L4-L9 之间抛出的异常被吃掉了。改为捕获异常,通过控制台输出异常信息,然后抛出异常。

@codecov-io
Copy link

codecov-io commented Dec 21, 2020

Codecov Report

Merging #5 (cd4d79a) into master (dae2845) will decrease coverage by 1.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   90.73%   89.42%   -1.31%     
==========================================
  Files           3        3              
  Lines         205      208       +3     
  Branches       13       13              
==========================================
  Hits          186      186              
- Misses         19       22       +3     
Impacted Files Coverage Δ
src/utils.ts 89.07% <100.00%> (-2.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae2845...cd4d79a. Read the comment docs.

For exceptions from Line:4-9 of cliFun() by bin/cli.js of @midwayjs/cli
ref: https://github.com/midwayjs/cli/blob/master/packages/cli/bin/cli.js#L4-L9
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #5 (8d4f1d1) into master (dae2845) will increase coverage by 3.71%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   90.73%   94.44%   +3.71%     
==========================================
  Files           3        3              
  Lines         205      252      +47     
  Branches       13       24      +11     
==========================================
+ Hits          186      238      +52     
+ Misses         19       14       -5     
Impacted Files Coverage Δ
src/utils.ts 96.93% <100.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae2845...8d4f1d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants