Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement feature: GitHub API Token support #192299

Closed
wants to merge 1 commit into from

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Nov 19, 2024

Note

This is a re-implementation, mostly copied from #168384

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This pull request is NOT about manifests.

Microsoft Reviewers: Open in CodeFlow

@Dragon1573 Dragon1573 requested review from denelon and a team as code owners November 19, 2024 03:38
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Nov 19, 2024
@denelon
Copy link
Contributor

denelon commented Nov 20, 2024

@Trenly & @mdanish-kh what are your thoughts here?

@Trenly
Copy link
Contributor

Trenly commented Nov 20, 2024

I don’t think this is a good implementation, as my logic was faulty when it was initially implemented. The token validation isn’t cached across runs, meaning that it can actually cause more issues than if the validation weren’t present.

I have several ideas on how to fix the caching issue, and would honestly prefer to do the implementation myself to ensure that it works without issue, as I'm sure @mdanish-kh will also want it to be integrated with PrTest, and I think that it may be beneficial to also integrate it with portions of YamlCreate

@Dragon1573
Copy link
Contributor Author

I don’t think this is a good implementation, as my logic was faulty when it was initially implemented. The token validation isn’t cached across runs, meaning that it can actually cause more issues than if the validation weren’t present.

I have several ideas on how to fix the caching issue, and would honestly prefer to do the implementation myself to ensure that it works without issue, as I'm sure @mdanish-kh will also want it to be integrated with PrTest, and I think that it may be beneficial to also integrate it with portions of YamlCreate

Thanks, the pull request will be closed. Waiting for official pull request of this feature. ❤️

@Dragon1573 Dragon1573 closed this Nov 20, 2024
@Dragon1573 Dragon1573 deleted the issues/189849 branch November 20, 2024 06:34
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Avoid "API rate limit"
5 participants