Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] how to develop vscode extensions locally with inter dependencies #35458

Closed
d-akara opened this issue Oct 1, 2017 · 8 comments
Closed
Assignees
Labels
extensions Issues concerning extensions info-needed Issue requires more information from poster

Comments

@d-akara
Copy link

d-akara commented Oct 1, 2017

I'm attempting to develop extensions which have a common dependency.
I use npm link to satisfy the dependency locally.

The problem is that I can't package the extension because vsce will fail due to npm saying there are extraneous modules. This is due to both modules requiring vscode.

The annoying work around is to uninstall the vscode from the common module before I package/publish. But this is an annoying workflow.

Is there a way to make this work properly?

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Oct 1, 2017
@joaomoreno
Copy link
Member

Can you show me the log from vsce?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Oct 2, 2017
@d-akara
Copy link
Author

d-akara commented Oct 2, 2017

@joaomoreno
Error: Command failed: npm list --production --parseable --depth=99999 npm ERR! extraneous: [email protected] /Users/chadmeadows/development/vscode-extensions/dakaraphi/vscode-extension-space-jumper/node_modules/vscode-extension-common/node_modules/vscode

vscode-extension-space-jumper is the extension I'm attempting to package.
vscode-extension-common is the module I've included via npm link

@joaomoreno
Copy link
Member

joaomoreno commented Oct 2, 2017

Is vscode listed in the dependencies object of vscode-extension-common/package.json?

@d-akara
Copy link
Author

d-akara commented Oct 2, 2017

yes

@joaomoreno
Copy link
Member

As a regular dependency? And the version matches what's on disk? Because that's what npm is complaining about.

@d-akara
Copy link
Author

d-akara commented Oct 2, 2017

hmm, ok. So I actually had it listed as devDependency.
So vsce does not complain if I move it to dependency; however, doesn't my package then unnecessarily include the vscode libraries?

@joaomoreno
Copy link
Member

Hm devDependency should actually work... Interesting.. that might be the issue here.

@joaomoreno
Copy link
Member

Moved to microsoft/vscode-vsce#207

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants