Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A suspicious file URL has been exposed in VSCode Insider #238438

Closed
James4Ever0 opened this issue Jan 22, 2025 · 1 comment
Closed

A suspicious file URL has been exposed in VSCode Insider #238438

James4Ever0 opened this issue Jan 22, 2025 · 1 comment
Assignees

Comments

@James4Ever0
Copy link

James4Ever0 commented Jan 22, 2025

Does this issue occur when all extensions are disabled?: Yes

System info:

Version: 1.97.0-insider (user setup)
Commit: 3d0aeb47a2ecfde9ff5141470b30c36d41c321d9
Date: 2025-01-20T05:04:25.114Z
Electron: 32.2.7
ElectronBuildId: 10660205
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.25300

Steps to Reproduce:

  1. Search for the keyword "file:///D:" in the VSCode installation folder
  2. Observe the suspicious string file:///D:/a/_work/1/s/extensions/microsoft-authentication/node_modules/@azure/msal-node-extensions/dist/Dpapi.mjs in resources\app\extensions\microsoft-authentication\dist\extension.js

Notes:

Have not found this string in VSCode code base. Maybe it is in the source code of @azure/msal-node-extensions, or the dependencies of microsoft-authentication.

@James4Ever0 James4Ever0 changed the title Suspicious file URL exposed in VSCode Insider A suspicious file URL exposed in VSCode Insider Jan 22, 2025
@James4Ever0 James4Ever0 changed the title A suspicious file URL exposed in VSCode Insider A suspicious file URL has been exposed in VSCode Insider Jan 22, 2025
@Tyriar Tyriar assigned TylerLeonhardt and unassigned Tyriar Jan 22, 2025
@TylerLeonhardt
Copy link
Member

Yes, it comes from here: https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/extensions/msal-node-extensions/src/Dpapi.ts

but it's for a feature of @azure/msal-node-extensions that we don't use at all, cache persistence. We brought this library in for a different feature, brokering. It's all doc'd here:
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/extensions/msal-node-extensions/README.md#about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants