Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme-color is not updated when the PWA is inactive. #236615

Open
a-stewart opened this issue Dec 19, 2024 · 1 comment · May be fixed by #236708
Open

theme-color is not updated when the PWA is inactive. #236615

a-stewart opened this issue Dec 19, 2024 · 1 comment · May be fixed by #236708
Assignees
@benibenj
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member titlebar VS Code main title bar issues web Issues related to running VSCode in the web
Milestone
Backlog

Comments

@a-stewart
Copy link
Contributor

  • VS Code Version: 1.97.0-insider
  • OS Version: PWA (Mac OS, but should apply to all)

Steps to Reproduce:

  1. Set the colour titleBar.inactiveBackground to something significantly different to the activeBackground to easily distinguish the focused app.
  2. Focus on any other app.

Image

Notice that even when the PWA is inactive, it still takes the theme-color from the active titlebar background.

https://github.com/microsoft/vscode/blob/main/src/vs/workbench/browser/style.ts#L27-L41

I think that ideally the theme-color would match the titlebar colour, regardless of whether the app is active or not.
@a-stewart a-stewart mentioned this issue Dec 19, 2024
Open
@aeschli aeschli assigned bpasero and unassigned aeschli Dec 20, 2024
@bpasero bpasero added titlebar VS Code main title bar issues web Issues related to running VSCode in the web labels Dec 20, 2024
@bpasero bpasero assigned benibenj and unassigned bpasero Dec 20, 2024
@benibenj benibenj added confirmation-pending help wanted Issues identified as good community contribution opportunities confirmed Issue has been confirmed by VS Code Team member bug Issue identified by VS Code Team member as probable bug and removed confirmation-pending labels Dec 20, 2024
@benibenj benibenj added this to the Backlog milestone Dec 20, 2024
@benibenj benibenj removed the help wanted Issues identified as good community contribution opportunities label Dec 20, 2024
@benibenj benibenj linked a pull request Dec 20, 2024 that will close this issue
Draft
@benibenj
Copy link
Contributor

benibenj commented Dec 20, 2024 •
edited
Loading

I was able to fix the reported problem, and the title bar renders correctly when merged together with the PWA title bar. When the title bar is not merged with the PWA title bar, there seems to be a border with a different color...
https://github.com/user-attachments/assets/b7b01392-9402-42a6-9e93-96548a51f74e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibenj benibenj

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member titlebar VS Code main title bar issues web Issues related to running VSCode in the web
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix PWA title bar theme color active vs inactive microsoft/vscode
4 participants
@a-stewart @bpasero @aeschli @benibenj