Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider how we might improve navigation to chat response content for screen reader users #228599

Open
meganrogge opened this issue Sep 13, 2024 · 2 comments · May be fixed by #236636
Open

Consider how we might improve navigation to chat response content for screen reader users #228599

meganrogge opened this issue Sep 13, 2024 · 2 comments · May be fixed by #236636
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Sep 13, 2024

@jooyoungseo has been interacting with the rendered HTML version of our chat responses more recently because of the introduction of the helpful hyperlinks.

He mentioned that there are several tab stops that are encountered before a screen reader user reaches the content of a chat response:

  1. the header
  2. the toolbar
  3. the references (if any)

He suggested that at least for windows/linux users, adding the role=document would help here. This wouldn't help macOS users and we probably want a solution that solves this for all platforms.

Another idea he had was to add a heading to the content so when a user enters a mode of their screen reader, they can go to it directly.

I mentioned that we're thinking about moving the toolbar (not sure about the references) to the bottom of the response. He raised concerns about the discoverability of the toolbar in that case for screen reader users but suggested that he has long thought a right click context menu would be advantageous and discoverable for users.

@roblourens or @rperez030 any thoughts?

@meganrogge meganrogge added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues under-discussion Issue is under discussion for relevance, priority, approach labels Sep 13, 2024
@jooyoungseo
Copy link

document role is also usable by Linux users.

@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Dec 19, 2024
@meganrogge meganrogge added this to the January 2025 milestone Dec 19, 2024
@meganrogge
Copy link
Contributor Author

I am thinking to move over to using the document role for windows and linux while keeping listitem for mac users. WDYT?

meganrogge added a commit that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants