Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title bar context menu entry in full screen to toggle menu bar on windows and linux #232780

Open
RedBlackAka opened this issue Nov 1, 2024 · 5 comments · May be fixed by #236608
Open

Add title bar context menu entry in full screen to toggle menu bar on windows and linux #232780

RedBlackAka opened this issue Nov 1, 2024 · 5 comments · May be fixed by #236608
Assignees
Labels
feature-request Request for new features or functionality linux Issues with VS Code on Linux menus Menu items and widget issues titlebar VS Code main title bar issues windows VS Code on Windows issues
Milestone

Comments

@RedBlackAka
Copy link

Do not hide the Menu Bar (that includes File, Edit, etc.) when entering fullscreen on Windows. It makes the fullscreen mode quite less usable. I really do like using it through!
Image
Image

@RedBlackAka
Copy link
Author

Realized that one can toggle it to always be visible in settings. I would however suggest making visible the default. And also keep the VSC icon on there. Thanks!

@bpasero bpasero assigned benibenj and unassigned bpasero Nov 1, 2024
@benibenj
Copy link
Contributor

benibenj commented Nov 1, 2024

I don't think we will be changing the default value here, however, we could add a context menu action on the title bar when in full screen to show/hide the menu. This would make it easier to discover and toggle

@benibenj benibenj added titlebar VS Code main title bar issues menus Menu items and widget issues labels Nov 1, 2024
@benibenj benibenj added the feature-request Request for new features or functionality label Dec 9, 2024
@benibenj benibenj added this to the Backlog milestone Dec 9, 2024
benibenj added a commit that referenced this issue Dec 19, 2024
@benibenj
Copy link
Contributor

I want to add a toggle Menu Bar action to the title bar when in full screen. Enabling sets it to visible, however, disabling is unclear. I was thinking to just set it to classic, but that could be confusing to some users as toggling out of full screen would show the menu bar again.

Maybe we need to call it Menu Bar in Full Screen which is a bit long and not nice, or have an action Hide Menu Bar in Full Screen (similar to the Hide Custom Title Bar In Full Screen) but I would prefer it to stay a toggle as that's what it is when not in full screen.

@bpasero thoughts?

@benibenj benibenj modified the milestones: Backlog, January 2025 Dec 19, 2024
@bpasero
Copy link
Member

bpasero commented Dec 19, 2024

I like to re-use existing settings and not have yet another one, even if the inverse is a bit confusing.

@benibenj benibenj changed the title Do not hide the Menu Bar when entering fullscreen (F11) on Windows Add title bar context menu entry in full screen to toggle menu bar on windows and linux Dec 19, 2024
@benibenj benibenj added linux Issues with VS Code on Linux windows VS Code on Windows issues labels Dec 19, 2024
@sbatten
Copy link
Member

sbatten commented Dec 19, 2024

@benibenj @bpasero If we are showing the title bar for some other reason in full screen (e.g. the command center or layout controls), I feel like hiding the menu bar in full screen with classic is actually strange. Essentially, that behavior originates from the native title bar. It would be nice to converge. If I were rewriting the settings, I'd probably have menubar be visible, toggle, compact. And have a new full screen titlebar visibility set to true / false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality linux Issues with VS Code on Linux menus Menu items and widget issues titlebar VS Code main title bar issues windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants