Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting escape when editing a comment should confirm cancellation. #1455

Open
rwspeight-orange opened this issue Nov 27, 2019 · 2 comments · May be fixed by microsoft/vscode#236589
Open

Hitting escape when editing a comment should confirm cancellation. #1455

rwspeight-orange opened this issue Nov 27, 2019 · 2 comments · May be fixed by microsoft/vscode#236589
Assignees
@alexr00
Labels
comments feature-request Request for new features or functionality upstream/vscode
Milestone
January 2025

Comments

@rwspeight-orange
Copy link

Hitting escape while editing a comment terminates edit mode and abandons unsaved work. Confirming the cancellation with the user would help prevent lost work and user frustration.
@rwspeight-orange rwspeight-orange changed the title Hitting escape when editing a comment should confirm cancellation of comment. Hitting escape when editing a comment should confirm cancellation. Nov 27, 2019
@RMacfarlane RMacfarlane added comments feature-request Request for new features or functionality labels Dec 2, 2019
@wcerfgba
Copy link

Yes please, this is easily the most frustrating problem I have with the extension at present. I can't tell you how many times I've accidentally knocked Esc and lost a PR comment with no way to recover it 😭

@RikkiGibson
Copy link
Member

It looks like this issue is still occurring. For comparison, if you hit esc while drafting a PR comment on the GitHub website, nothing happens.

@alexr00 alexr00 self-assigned this Aug 22, 2024
@alexr00 alexr00 added this to the September 2024 milestone Aug 22, 2024
@alexr00 alexr00 modified the milestones: September 2024, October 2024 Sep 23, 2024
@jamesgecko jamesgecko mentioned this issue Oct 3, 2024
Closed
@alexr00 alexr00 modified the milestones: October 2024, November 2024 Oct 21, 2024
@forivall forivall mentioned this issue Oct 23, 2024
Closed
@alexr00 alexr00 modified the milestones: November 2024, January 2025 Dec 3, 2024
alexr00 added a commit to microsoft/vscode that referenced this issue Dec 19, 2024
@alexr00
Add a setting to warn when collapsing unsubmitted comments
039b5f0 
Fixes microsoft/vscode-pull-request-github#1455
@alexr00 alexr00 linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
comments feature-request Request for new features or functionality upstream/vscode
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Add a setting to warn when collapsing unsubmitted comments microsoft/vscode
5 participants
@wcerfgba @RMacfarlane @RikkiGibson @rwspeight-orange @alexr00