Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual hover no longer closes on Esc or click outside #236193

Closed
rthrfrd opened this issue Dec 16, 2024 · 5 comments
Closed

Manual hover no longer closes on Esc or click outside #236193

rthrfrd opened this issue Dec 16, 2024 · 5 comments
Assignees

Comments

@rthrfrd
Copy link

rthrfrd commented Dec 16, 2024

Does this issue occur when all extensions are disabled?: Don't know
Without extensions there are no hovers, so it would not be possible to reproduce it.

  • VS Code Version: 1.96.0
  • OS Version: macOS 14.7

Steps to Reproduce:

  1. Disable hover on mouseover (via editor.hover.enabled).
  2. Bind a shortcut to show the hover (via editor.action.showHover).
  3. Place your cursor in a symbol in your code and press your shortcut to display the hover.
  4. Hit Escape - or click away outside of the hover: The hover will not close.
vscode.mov

Notes:

  • This could be solved by the user if there was a corresponding editor.action.closeHover shortcut that could be bound to Escape, but the click-out functionality would still be broken.
  • Changing editor.hover.sticky seems to have no effect on the issue.
  • Focusing the hover and then pressing Escape will close it.
@synalice
Copy link

Was just about to create an issue about that. Exactly my problem. Something changed with a new update...

I now have to press the shortcut to show the hover twice (once to show it, twice to focus). This completely broke my workflow :(

@synalice

This comment has been minimized.

@synalice
Copy link

One possible solution could have been using runCommands (built-in command as of v1.77):

"key": "ctrl+k ctrl+i`",
"command": "runCommands",
"args": {
    "commands": [
        "editor.action.showHover",
        "editor.action.showHover",
    ]
}

Unfortunately, this doesn't work...

@rthrfrd
Copy link
Author

rthrfrd commented Dec 16, 2024

Oh I just saw your PR #236203 @aiday-mar and it looks like #235979 is basically the same issue with a different path in - sorry didn't see that one - you can probably just close this one!

@aiday-mar
Copy link
Contributor

Hi @rthrfrd yes thank you for filing this issue. That is right, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants