Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate @example code blocks as typescript for better highlights #234142

Closed
ribru17 opened this issue Nov 18, 2024 · 6 comments · Fixed by #234143
Closed

Annotate @example code blocks as typescript for better highlights #234142

ribru17 opened this issue Nov 18, 2024 · 6 comments · Fixed by #234143
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone

Comments

@ribru17
Copy link
Contributor

ribru17 commented Nov 18, 2024

It would be nice if markdown code blocks produced by @example tags in JSDoc were annotated as typescript so Markdown renderers can provide nice highlights for JS/TS code examples.

@mjbvz mjbvz added this to the November 2024 milestone Nov 20, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 22, 2024
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug author-verification-requested Issues potentially verifiable by issue author labels Dec 2, 2024
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@ribru17, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 2ed1e9b of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@alexr00
Copy link
Member

alexr00 commented Dec 5, 2024

This looks like this is already fixed in 1.95:

Image

Am I looking in the right place?

@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Dec 5, 2024
@ribru17
Copy link
Contributor Author

ribru17 commented Dec 5, 2024

This is the right place, looks like it is fixed! Thanks for checking

@alexr00
Copy link
Member

alexr00 commented Dec 5, 2024

My screen shot is from 1.95, before the fix was made.

@ribru17
Copy link
Contributor Author

ribru17 commented Dec 5, 2024

I see. I can confirm the effect of this change soon then, I do not use VS code but rather the vtsls wrapper which is where I noticed markdown blocks were not highlighted. Perhaps the vs code client handles this special case internally already

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 6, 2024

Marking as verified on the VS Code based on looking at the rendered html in the hover

Once toy can test this with vtsls please let me know if there are any issues

@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants