Cannot package with vsce if using a linked package

[chrisvrose]

My project uses a module linked from another location.
Doing either vsce package or vsce ls throws a

path should be a `path.relative()`d string, but got "../otherProject/node_modules/@types/chai/index.d.ts"

(The other repository uses chai for testing)

.vscodeignore has been set up to ignore node_modules for the current project, which is where the symlink to otherProject is (as I said, linked repository).

Once unlinked, I can package the repository and the resulting extension works fine (Because really I want to package the webpack-ed files, and I don't need the rest)

Of course, this isn't really an optimal solution as unlinking, compiling then linking is not really nice.

[chrisvrose]

This seems to be because the ignore module does not like locations starting with ../ for ignoring (which is a legitimate path.relative output but it is not accepted)

[joaomoreno]

Do you expect the linking to simply be resolved during packaging?

[chrisvrose]

Do you expect the linking to simply be resolved during packaging?

The linked module is in node_modules, which is part of my .vscodeignore, so I'm expecting it to be ignored. Instead I end up with the above error.

.vscodeignore contents:

.vscode/**
.vscode-test/**
node_modules/**

client/**
server/**
webpack.config.js
.gitignore
.yarnrc
vsc-extension-quickstart.md
**/tsconfig.json
**/.eslintrc.json
**/*.map
**/*.ts

EDIT: Add:
This can be reproduced by npm link <any package> and then trying to package (as long as that package you're trying to include is not under the current repo), even if node_modules is under .vscodeignore

[Vtec234]

You might have some luck using 1.91.0, before #418 was merged. In that version vsce still tries to pull in the entire contents of the linked folder (node_modules and so on), but you can stop that by putting ../** in .vscodeignore.

More generally, including everything except .vscodeignore by default seems to cause a lot of trouble -- I would suggest revisiting #12.

[chrisvrose]

You might have some luck using 1.91.0, before #418 was merged. In that version vsce still tries to pull in the entire contents of the linked folder (node_modules and so on), but you can stop that by putting ../** in .vscodeignore.

More generally, including everything except .vscodeignore by default seems to cause a lot of trouble -- I would suggest revisiting #12.

Thank you! I reverted back to v1.91.0 and it seems to work perfectly with your mentioned change.
Its a better workaround than unlinking and packaging then linking again.

Edit: With the revert to minimatch in v1.95, the above method works as well.

[joaomoreno]

#308