Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package command not working when used with rush #399

Closed
cazfletch opened this issue Nov 14, 2019 · 3 comments
Closed

Package command not working when used with rush #399

cazfletch opened this issue Nov 14, 2019 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@cazfletch
Copy link

I am using rush and yarn to create a mono repo. However when i try and package my extension no node modules are added to the package. I am using the --yarn option. Without have a mono repo it packages fine. I think it is something to do with the node modules being symlinked. Help with this would be very much appreciated

@joaomoreno joaomoreno self-assigned this Nov 19, 2019
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Nov 19, 2019
@joaomoreno
Copy link
Member

Can you point me to what rush is?

@cazfletch
Copy link
Author

Here is a link https://rushjs.io/. I found that packaging also doesn't work using npm and rush either. I tried another tool called lerna for creating a mono repo https://github.com/lerna/lerna and that worked better but any packages you have as dependencies in the mono repo vsce claims it cant find them as they are symlinked.

Using lerna, I got around the problem by using npm pack to create a tar ball and then installing that before doing a package. That seems to work but it would be better not to have to do this.

@joaomoreno
Copy link
Member

#203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants