Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

mohankumarelec · 2024-11-09T06:09:09Z

The Regex used for checking valid engine version, can have values like 1.96.x, which is not a valid semver.
When using these kinds of version, the semver version comparison fails.

vscode-vsce/src/validation.ts

Lines 51 to 53 in f1fc6d2

    
           if (!/^\*$|^(\^|>=)?((\d+)|x)\.((\d+)|x)\.((\d+)|x)(\-.*)?$/.test(version)) { 
        
           	throw new Error(`Invalid vscode engine compatibility version '${version}'`); 
        
           }

vscode-vsce/src/package.ts

Line 506 in f1fc6d2

    
           if (engineVersion !== 'latest' && !semver.satisfies(engineVersion, '>=1.61', { includePrerelease: true })) {

mohankumarelec linked a pull request Nov 9, 2024 that will close this issue

Updated the semver comparison #1078

Open

benibenj added the feature-request Request for new features or functionality label Nov 25, 2024

benibenj added this to the January 2025 milestone Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

mohankumarelec commented Nov 9, 2024

Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

Comments

mohankumarelec commented Nov 9, 2024