Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't exclude files that match an include glob #1066

Open
adrianstephens opened this issue Oct 12, 2024 · 1 comment
Open

Can't exclude files that match an include glob #1066

adrianstephens opened this issue Oct 12, 2024 · 1 comment
Labels
feature-request Request for new features or functionality

Comments

@adrianstephens
Copy link

vsce version 3.1.1

I'm trying to skip photoshop source images in my assets directory.
I've tried this in package.json:

	"files": [
		"dist/**/*.js",
		"assets/*",
        "!assets/*.psd",
		"LICENSE.txt"
	],

which gave:

ERROR  The following include patterns in the "files" property in package.json do not match any files packaged in the extension:
  - D:/dev/vscode_ext/modules/!assets/*.psd
Remove any include pattern which is not needed.

and this in .vscodeignore:

# Ignore everything by default
*
*/**

# Then explicitly include what you want
!dist/**/*.js
!assets/**
!LICENSE.txt
!README.md
!package.json

# Exclude specific files
assets/icon.psd
**/*.psd
**/*.PSD

Which gave no errors, but included the psds anyway.

I'm assuming this is a bug, but if I'm just doing this wrong, apologies!

Adrian Stephens

@adrianstephens
Copy link
Author

Note, I made a fix here:
#1067

@benibenj benibenj added the feature-request Request for new features or functionality label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants