You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Repository Clone Configuration (single repository/fork of an upstream repository): single repository with submodules
Github Product (Github.com/Github Enterprise version x.x.x): Github.com
Steps to Reproduce:
tl;dr: On PR create for submodule, extension will fork main repository instead of submodule.
Looks like it's the same as #4487 #5181
We found issue on diplodoc metapackage. But it is reproducible on any repo with submodules.
Prerequisites: Metapackage - organisation owned repo with submodules and enabled codespaces. Submodule - any organisation owned repo linked to metapackage. Alice - user out of organization scope.
Create codespace for metapackage and open it in browser VSCode
Pull submodules. We use this small script to pull all submodules in one time, but looks like there is nothing special.
Make some change to submodule.
Create new branch in submodule. Commit changes (with help of Github Pull Request Extension)
Push the button "Create Pull Request"
Check autofilled fields (looks like at this step all is normal: BASE and MERGE fields refers to submodule branches)
Push "Create" button.
VSCode notifies Alice about restriction to pull directly to organization and proposes to create fork.
Submit to fork submodule
9.1 Current behaviour: fork for metapackage was created, pr flow was broken on next step with reasonable error.
9.2 Expected behaviour: fork for submodule was created, pr flow finished succesefully.
At second try to push "Create" button error message was changed to
The text was updated successfully, but these errors were encountered:
Steps to Reproduce:
tl;dr: On PR create for submodule, extension will fork main repository instead of submodule.
Looks like it's the same as
#4487
#5181
We found issue on diplodoc metapackage. But it is reproducible on any repo with submodules.
Prerequisites:
Metapackage - organisation owned repo with submodules and enabled codespaces.
Submodule - any organisation owned repo linked to metapackage.
Alice - user out of organization scope.
9.1 Current behaviour: fork for metapackage was created, pr flow was broken on next step with reasonable error.
9.2 Expected behaviour: fork for submodule was created, pr flow finished succesefully.
The text was updated successfully, but these errors were encountered: