Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File-level comments expand on navigation to the file despite collapseAll #6465

Closed
MetRonnie opened this issue Nov 8, 2024 · 2 comments · Fixed by microsoft/vscode#236201
Closed

File-level comments expand on navigation to the file despite collapseAll #6465

MetRonnie opened this issue Nov 8, 2024 · 2 comments · Fixed by microsoft/vscode#236201
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2025

Comments

@MetRonnie
Copy link

MetRonnie commented Nov 8, 2024 •
edited
Loading

  • Extension version: v0.100.0
  • VSCode Version: 1.95.1
  • OS: Windows_NT x64 10.0.19045 / Linux x64 5.14.0-427.40.1.el9_4.x86_64
  • Repository Clone Configuration (single repository/fork of an upstream repository): It's a clone with both the original repo and personal fork as remotes
  • Github Product (Github.com/Github Enterprise version x.x.x): github.com

Steps to Reproduce:

  1. Set vscode://settings/githubPullRequests.commentExpandState to collapseAll (I did this a long time ago)
  2. When reviewing a PR with a (resolved) file-level comment, navigating to that file always expands the comment
vscode-gh-prs-bug.mp4

This appears to be the same issue as #5512 but was not fixed in #5540, or is a regression?
@MetRonnie
Copy link
Author

Additional context: this is happening on a PR that has >100 comments already

@alexr00 alexr00 self-assigned this Dec 16, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 16, 2024
@alexr00 alexr00 added this to the January 2025 milestone Dec 16, 2024
@alexr00
Copy link
Member

alexr00 commented Dec 16, 2024

File level comments can be a bit difficult to find, so we always expand them. I'll change it.

@alexr00 alexr00 closed this as completed Dec 16, 2024
alexr00 added a commit to microsoft/vscode that referenced this issue Dec 16, 2024
@alexr00
Allow file level comments to start collapsed
cfb1bdb 
Fixes microsoft/vscode-pull-request-github#6465
@alexr00 alexr00 mentioned this issue Dec 16, 2024
Merged
alexr00 added a commit to microsoft/vscode that referenced this issue Dec 16, 2024
@alexr00
Allow file level comments to start collapsed (#236201)
8db8225 
Fixes microsoft/vscode-pull-request-github#6465
@meganrogge meganrogge added the verified Verification succeeded label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Allow file level comments to start collapsed microsoft/vscode
3 participants
@meganrogge @alexr00 @MetRonnie