-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Pre-built Jekyll image #919
Comments
Moving our convos here versus slack!
We're now discussing if it makes sense to have an overarching general use Jekyll image as well as a more specific one geared to GitHub pages. My thought is that we want to have one image that ideally works for both so that we don't have to deal with the maintenance of two very similar images and definitions. The lastest question from @parkr is "could we |
If you're worried about post-creation command speed, then the best bet is to install the |
//cc: @cmendible as well since we'd be converting that definition into a pre-built one. @parkr So: FROM mcr.microsoft.com/vscode/devcontainers/ruby:2
# ...
RUN gem install bundler jekyll github-pages ...and have a pre-built image with all this in it. Then leave https://github.com/microsoft/vscode-dev-containers/blob/main/containers/jekyll/.devcontainer/post-create.sh largely as-is. That accurate? |
Put up a PR for review (#929). Let me know if it looks good. |
@parkr Quick check-in: Any feedback here? |
@parkr @2percentsilk Okay, development image is up. See what you think! $ docker run -it --rm mcr.microsoft.com/vscode/devcontainers/jekyll:dev bash |
I noticed this is using Ruby 3.0 because of #944 - I assume that's a problem? I'll work on a fix. |
Ok - that's fixed as well. |
This is being published with the v0.188.0 release. We can adjust from there. |
I couldn't get this to work in the Apple M1. Previously worked awesomely in the Intel version. So switched to the base.Dockerfile in the ruby devcontainer with the 2.7.2 variant and it works. |
@kosalanuwan We do not pre-build M1 images due to docker buildx failures. See #558 |
Jekyll is used heavily throughout GitHub and generally in static web sites. We can pre-build a version of this image for use. @2percentsilk and @parkr are discussing requirements.
The text was updated successfully, but these errors were encountered: