.clang-tidy config file doesn't work

[demberto]

Before going ahead and opening an issue, I want to confirm whether .clang-tidy doesn't work with a hierarchy like this:

├─── .vscode
├─── build
├─── .clang-tidy
├─── src.c
└─── src.h

This is what .clang-tidy has

---
Checks: '-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling'
---

This doesn't work, but adding it to project wide settings.json like this works:

{
    "C_Cpp.codeAnalysis.clangTidy.checks.disabled": ["clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling"]
}

[sean-mcmanus]

The .clang-tidy (or .clang-format) file is only picked up at the sibling or parent level in relation to a source file, so if you have a .clang-tidy file in some subfolder, it won't get picked up. The detection of the .clang-tidy is done by the clang-tidy executable itself and not our extension (the only spot where our extension check for .clang-tidy when determining when the "C_Cpp.codeAnalysis.clangTidy.fallbackConfig" setting should be used).

[demberto]

The setting you mentioned is empty. I can reproduce the same issue if I make subdirectories for the source code, and keep .clang-tidy. What really makes me think its an extension only issue is that configuring via C_Cpp.codeAnalysis.clangTidy.checks.disabled works perfectly.

[demberto]

Something is really messed up, even the codeAnalysis exclusion doesn't work either

[sean-mcmanus]

I see clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling not working at all in the .clang-tidy file or the disabled setting and I need to use clang-diagnostic-deprecated-declarations.

I'm seeing the C_Cpp.codeAnalysis.exclude setting working. I'm not sure what could be causing it to not work -- what OS are you on? There might be some issue with the exclude regex not matching a path for some reason, such as having a symlink on the path.

[demberto]

I am on Windows and external contains submodules, I tried quite a few combinations, none of them worked. Should I open an issue for the .clang-tidy file (in clang-tidy repo)?

[sean-mcmanus]

If you think there is a bug with our extension's handling of the .clang-tidy file you should file a bug on our extension...otherwise if you can get a repro via running clang-tidy from the command line then you should report the bug on the LLVM GitHub page.