From a07c8fd6c09cab1d8b36d8d0474890e2cb9b3f7e Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Mon, 14 Mar 2022 17:11:44 -0700 Subject: [PATCH] Undo detached. (#9026) * Undo detached. * Update changelog. --- Extension/CHANGELOG.md | 8 +++++--- Extension/src/LanguageServer/client.ts | 6 ++++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/Extension/CHANGELOG.md b/Extension/CHANGELOG.md index f28d984b70..539bcd5d92 100644 --- a/Extension/CHANGELOG.md +++ b/Extension/CHANGELOG.md @@ -1,13 +1,15 @@ # C/C++ for Visual Studio Code Change Log -## Version 1.9.4-debug: March 11, 2022 +## Version 1.9.4-debug: March 14, 2022 * This is a debug build for Windows x64 intended to be used to get assertion failure information for bug [#8851](https://github.com/microsoft/vscode-cpptools/issues/8851). -## Enhancement +## Enhancements +* Reserved identifiers with characters that match typed characters in the correct order but not contiguously are initially filtered in the auto-completion list. Doing a `ctrl` + `space` in the same location will show all auto-complete suggestions. [#4939](https://github.com/microsoft/vscode-cpptools/issues/4939) * Show "Catastrophic error" during tag parsing with an Error logging severity and report the number of occurrences via telemetry. [#9013](https://github.com/microsoft/vscode-cpptools/issues/9013) -## Bug Fix +## Bug Fixes * Fix temp files randomly not getting deleted on Windows with a `C_Cpp.loggingLevel` of `Warning` or greater. [#9008](https://github.com/microsoft/vscode-cpptools/issues/9008) +* Fix mingw clang being detected as gcc. [#9024](https://github.com/microsoft/vscode-cpptools/issues/9024) ## Version 1.9.3: March 9, 2022 ### New Feature diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts index d151922287..367dde96e3 100644 --- a/Extension/src/LanguageServer/client.ts +++ b/Extension/src/LanguageServer/client.ts @@ -1076,8 +1076,10 @@ export class DefaultClient implements Client { } const serverName: string = this.getName(this.rootFolder); const serverOptions: ServerOptions = { - run: { command: serverModule, options: { detached: true } }, - debug: { command: serverModule, args: [serverName], options: { detached: true } } + // Running detached would be preferred; however, that causes cpptools-srv to create a console window + // on Windows and that can't seem to be suppressed without suppressing assertion dialog boxes. + run: { command: serverModule, options: { detached: false } }, + debug: { command: serverModule, args: [serverName], options: { detached: false } } }; // Get all the per-workspace settings.