Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msh3] update to 0.7.0 #41200

Open
talregev opened this issue Sep 26, 2024 · 3 comments · May be fixed by #42788
Open

[msh3] update to 0.7.0 #41200

talregev opened this issue Sep 26, 2024 · 3 comments · May be fixed by #42788
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@talregev
Copy link
Contributor

talregev commented Sep 26, 2024

Library name

msh3

New version number

0.7.0

Other information that may be useful (release notes, etc...)

it needed to change also msquick:
https://github.com/microsoft/msquic/blob/v2.3.5/src/inc/quic_platform.h#L574
That needed c++ define:
https://github.com/microsoft/msquic/blob/v2.3.5/src/inc/quic_platform.h#L498

Not sure how to do that.

When I tried to update:

msh3.cpp.obj : error LNK2001: unresolved external symbol CxPlatGetSelfSignedCert
msh3.cpp.obj : error LNK2001: unresolved external symbol CxPlatFreeSelfSignedCert
bin\msh3.dll : fatal error LNK1120: 2 unresolved externals

ninja: build stopped: subcommand failed.

I am not sure how to compile these symbol. I know they are depends on define cpp: QUIC_TEST_APIS
https://github.com/microsoft/msquic/blob/v2.3.5/src/inc/quic_platform.h#L498

I tried to add it via port config with VCPKG_CXX_FLAGS with both define in msquic and msh3, but without success.

@talregev talregev added the category:port-update The issue is with a library, which is requesting update new revision label Sep 26, 2024
@talregev talregev changed the title [msh3] update to <0.7.0> [msh3] update to 0.7.0 Sep 26, 2024
@talregev
Copy link
Contributor Author

I create issue on upstream of msquic:
microsoft/msquic#4569

I also suggested some solution:
microsoft/msquic#4574

Let's see what happen.

@talregev
Copy link
Contributor Author

It needed msquic 2.4.7 or more.
#42755

@MonicaLiu0311
Copy link
Contributor

Fixing by #42788.

@MonicaLiu0311 MonicaLiu0311 linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants