Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass keyboard layout down to ConPTY and consider readding support for GetConsoleKeyboardLayoutName #18160

Open
lhecker opened this issue Nov 6, 2024 · 0 comments
Open

Pass keyboard layout down to ConPTY and consider readding support for GetConsoleKeyboardLayoutName #18160

lhecker opened this issue Nov 6, 2024 · 0 comments
Labels
Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Conhost For issues in the Console codebase Product-Conpty For console issues specifically related to conpty
Milestone
Backlog

Comments

@lhecker
Copy link
Member

lhecker commented Nov 6, 2024

Description of the new feature

To help PowerShell with their ToUnicode usage we should pass down the keyboard layout to ConPTY so that their keyboard-layout hack works:
https://github.com/PowerShell/PSReadLine/blob/e87a265ef8d2c6c5498500deb155bf6258b34629/PSReadLine/PlatformWindows.cs#L1106-L1109

To avoid the need for such a workaround, we should readd support for the existing GetConsoleKeyboardLayoutName function. There's not really a good reason to not support it. It's also used by vim and probably others so it may be quite helpful.

Proposed technical implementation details

No response
@lhecker lhecker added Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase Product-Conpty For console issues specifically related to conpty labels Nov 6, 2024
@lhecker lhecker added this to the Backlog milestone Nov 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Conhost For issues in the Console codebase Product-Conpty For console issues specifically related to conpty
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@lhecker