Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to change border colors #18125

Open
theactualmariluski opened this issue Oct 30, 2024 · 2 comments
Open

Add an option to change border colors #18125

theactualmariluski opened this issue Oct 30, 2024 · 2 comments
Labels
Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@theactualmariluski
Copy link

Description of the new feature

Add an option to change border colors
I had this idea of making so you can change the border colors.

This is specially usefull when you have multiple windows and you dont want to use a terminal multiplexer.

Proposed technical implementation details

I don't know if the way VSCode is made and the Window terminal nad if they are a bit compatible.
There is a VSCode extension called peacock that changes border colors

@theactualmariluski theactualmariluski added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 30, 2024
@zadjii-msft
Copy link
Member

zadjii-msft commented Oct 30, 2024

xlinking for my own sake:
Image

https://www.peacockcode.dev/

Looks a lot like different Themes.

#9818 has a note about previewing different themes (though, I don't think it's tracked anywhere specific?)

then there's also the idea of per-window themes (which would be enabled by #9992)

then there's also "workspaces" which I'm tracking in #17084, which would allow a similar idea of setting global settings on a window name and you can save that window name. Kinda would also play into this.

There's also already $theme.$window.frame for controlling the window border

@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Area-Theming Anything related to the theming of elements of the window and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 30, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Oct 30, 2024
@zadjii-msft
Copy link
Member

So, just for my own notekeeping - would an action that lets you switch between themes be sufficient here?

@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. Help Wanted We encourage anyone to jump in on these. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants