Fix the issue with accessing the shouldEnsureConsistentVersions method. (#5063)

Author: fzxen

common/changes/@microsoft/rush/bugfix-no-unnecessary-condition_2025-01-03-10-05.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue with evaluation of `shouldEnsureConsistentVersions` when the value is not constant across subspaces or variants.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

libraries/rush-lib/src/cli/actions/VersionAction.ts

@@ -216,8 +216,8 @@ export class VersionAction extends BaseRushAction {
     // Validate result of all subspaces
     for (const subspace of rushConfig.subspaces) {
       // Respect the `ensureConsistentVersions` field in rush.json
-      if (!subspace.shouldEnsureConsistentVersions) {
-        return;
+      if (!subspace.shouldEnsureConsistentVersions(variant)) {
+        continue;
       }
 
       const mismatchFinder: VersionMismatchFinder = VersionMismatchFinder.getMismatches(rushConfig, {