Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apple): improved Node finder #2267

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix(apple): improved Node finder #2267

merged 1 commit into from
Oct 2, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 1, 2024

Description

See facebook/react-native@aa35a21

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

CI should pass.

@tido64
Copy link
Member Author

tido64 commented Oct 1, 2024

cc @okwasniewski

@tido64 tido64 merged commit 20ca146 into trunk Oct 2, 2024
27 checks passed
@tido64 tido64 deleted the tido/find-node-2 branch October 2, 2024 06:55
@atlj
Copy link

atlj commented Oct 18, 2024

@tido64 thanks for this. Looks like this also fixed an issue with asdf. With the way asdf treats the node shim, calling file on it returns Bourne-Again shell script text executable, ASCII text. Which doesn't include Mach-O therefore raising an error.

Here's an example from bob callstack/react-native-builder-bob#639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants