From 33299ce41267648eefa17ca31546ad321544efa2 Mon Sep 17 00:00:00 2001 From: Saad Najmi Date: Thu, 2 Nov 2023 14:57:06 -0700 Subject: [PATCH 1/2] [CI] Add jobs to test static frameworks --- .ado/jobs/build-test-rntester.yml | 111 +++++++++++++++++++++++++++++- 1 file changed, 109 insertions(+), 2 deletions(-) diff --git a/.ado/jobs/build-test-rntester.yml b/.ado/jobs/build-test-rntester.yml index d243ef28d7f85f..a28aaf714357f1 100644 --- a/.ado/jobs/build-test-rntester.yml +++ b/.ado/jobs/build-test-rntester.yml @@ -9,6 +9,7 @@ parameters: packager_platform: 'macos' new_arch_enabled: '0' use_hermes: '0' + use_frameworks: '0' - name: macos_newarch_jsc friendly_name: 'macOS, New Arch, JSC' sdk: macosx @@ -16,6 +17,7 @@ parameters: packager_platform: 'macos' new_arch_enabled: '1' use_hermes: '0' + use_frameworks: '0' # - name: macos_oldarch_hermes # friendly_name: 'macOS, Old Arch, Hermes' # sdk: macosx @@ -23,6 +25,7 @@ parameters: # packager_platform: 'macos' # new_arch_enabled: '1' # use_hermes: '1' + # use_frameworks: '0' # - name: macos_newarch_hermes # friendly_name: 'macOS, New Arch, Hermes' # sdk: macosx @@ -30,6 +33,7 @@ parameters: # packager_platform: 'macos' # new_arch_enabled: '1' # use_hermes: '1' + # use_frameworks: '0' - name: ios_oldarch_jsc friendly_name: 'iOS, Old Arch, JSC' sdk: iphonesimulator @@ -37,6 +41,7 @@ parameters: packager_platform: 'ios' new_arch_enabled: '0' use_hermes: '0' + use_frameworks: '0' - name: ios_newarch_jsc friendly_name: 'iOS, New Arch, JSC' sdk: iphonesimulator @@ -44,6 +49,7 @@ parameters: packager_platform: 'ios' new_arch_enabled: '1' use_hermes: '0' + use_frameworks: '0' # - name: ios_oldarch_hermes # friendly_name: 'iOS, Old Arch, Hermes' # sdk: iphonesimulator @@ -51,6 +57,7 @@ parameters: # packager_platform: 'ios' # new_arch_enabled: '1' # use_hermes: '1' + # use_frameworks: '0' # - name: ios_newarch_hermes # friendly_name: 'iOS, New Arch, Hermes' # sdk: iphonesimulator @@ -58,6 +65,7 @@ parameters: # packager_platform: 'ios' # new_arch_enabled: '1' # use_hermes: '1' + # use_frameworks: '0' - name: xros_oldarch_jsc friendly_name: 'xrOS, Old Arch, JSC' sdk: xrsimulator @@ -65,6 +73,7 @@ parameters: packager_platform: 'ios' new_arch_enabled: '0' use_hermes: '0' + use_frameworks: '0' - name: xros_newarch_jsc friendly_name: 'xrOS, New Arch, JSC' sdk: xrsimulator @@ -72,20 +81,117 @@ parameters: packager_platform: 'ios' new_arch_enabled: '1' use_hermes: '0' - # - name: xros_oldarch_hermes + use_frameworks: '0' + # - name: xros_oldarch_hermes_framework # friendly_name: 'xrOS, Old Arch, Hermes' # sdk: xrsimulator # scheme: RNTester-visionOS # packager_platform: 'ios' # new_arch_enabled: '1' # use_hermes: '1' - # - name: xros_newarch_hermes + # use_frameworks: '0' + # - name: xros_newarch_hermes_framework # friendly_name: 'xrOS, New Arch, Hermes' # sdk: xrsimulator # scheme: RNTester-visionOS # packager_platform: 'ios' # new_arch_enabled: '1' # use_hermes: '1' + # use_frameworks: '0' + - name: macos_oldarch_jsc_framework + friendly_name: 'macOS, Old Arch, JSC, Framework' + sdk: macosx + scheme: RNTester-macOS + packager_platform: 'macos' + new_arch_enabled: '0' + use_hermes: '0' + use_frameworks: '1' + - name: macos_newarch_jsc_framework + friendly_name: 'macOS, New Arch, JSC, Framework' + sdk: macosx + scheme: RNTester-macOS + packager_platform: 'macos' + new_arch_enabled: '1' + use_hermes: '0' + use_frameworks: '1' + # - name: macos_oldarch_hermes_framework + # friendly_name: 'macOS, Old Arch, Hermes, Framework' + # sdk: macosx + # scheme: RNTester-macOS + # packager_platform: 'macos' + # new_arch_enabled: '1' + # use_hermes: '1' + # - name: macos_newarch_hermes_framework + # friendly_name: 'macOS, New Arch, Hermes, Framework' + # sdk: macosx + # scheme: RNTester-macOS + # packager_platform: 'macos' + # new_arch_enabled: '1' + # use_hermes: '1' + # use_frameworks: '1' + - name: ios_oldarch_jsc_framework + friendly_name: 'iOS, Old Arch, JSC, Framework' + sdk: iphonesimulator + scheme: RNTester + packager_platform: 'ios' + new_arch_enabled: '0' + use_hermes: '0' + use_frameworks: '1' + - name: ios_newarch_jsc_framework + friendly_name: 'iOS, New Arch, JSC, Framework' + sdk: iphonesimulator + scheme: RNTester + packager_platform: 'ios' + new_arch_enabled: '1' + use_hermes: '0' + use_frameworks: '1' + # - name: ios_oldarch_hermes_framework + # friendly_name: 'iOS, Old Arch, Hermes, Framework' + # sdk: iphonesimulator + # scheme: RNTester + # packager_platform: 'ios' + # new_arch_enabled: '1' + # use_hermes: '1' + # - name: ios_newarch_hermes + # friendly_name: 'iOS, New Arch, Hermes, Framework' + # sdk: iphonesimulator + # scheme: RNTester + # packager_platform: 'ios' + # new_arch_enabled: '1' + # use_hermes: '1' + # use_frameworks: '1' + - name: xros_oldarch_jsc_framework + friendly_name: 'xrOS, Old Arch, JSC, Framework' + sdk: xrsimulator + scheme: RNTester-visionOS + packager_platform: 'ios' + new_arch_enabled: '0' + use_hermes: '0' + use_frameworks: '1' + - name: xros_newarch_jsc_framework + friendly_name: 'xrOS, New Arch, JSC, Framework' + sdk: xrsimulator + scheme: RNTester-visionOS + packager_platform: 'ios' + new_arch_enabled: '1' + use_hermes: '0' + use_frameworks: '1' + # - name: xros_oldarch_hermes_framework + # friendly_name: 'xrOS, Old Arch, Hermes, Framework' + # sdk: xrsimulator + # scheme: RNTester-visionOS + # packager_platform: 'ios' + # new_arch_enabled: '1' + # use_hermes: '1' + # use_frameworks: '1' + # - name: xros_newarch_hermes_framework + # friendly_name: 'xrOS, New Arch, Hermes, Framework' + # sdk: xrsimulator + # scheme: RNTester-visionOS + # packager_platform: 'ios' + # new_arch_enabled: '1' + # use_hermes: '1' + # use_frameworks: '1' jobs: - ${{ each slice in parameters.appleBuildMatrix }}: @@ -119,6 +225,7 @@ jobs: env: RCT_NEW_ARCH_ENABLED: ${{ slice.new_arch_enabled }} USE_HERMES: ${{ slice.use_hermes }} + USE_FRAMEWORKS: ${{ slice.use_frameworks }} workingDirectory: packages/rn-tester displayName: Install Pods From ca36e394aeb1ec5465f2ff723d46690ec8a902cd Mon Sep 17 00:00:00 2001 From: Saad Najmi Date: Thu, 12 Dec 2024 18:41:26 -0800 Subject: [PATCH 2/2] try static frameworks --- .ado/jobs/build-test-rntester.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.ado/jobs/build-test-rntester.yml b/.ado/jobs/build-test-rntester.yml index a28aaf714357f1..1426c4b9056357 100644 --- a/.ado/jobs/build-test-rntester.yml +++ b/.ado/jobs/build-test-rntester.yml @@ -105,7 +105,7 @@ parameters: packager_platform: 'macos' new_arch_enabled: '0' use_hermes: '0' - use_frameworks: '1' + use_frameworks: 'static' - name: macos_newarch_jsc_framework friendly_name: 'macOS, New Arch, JSC, Framework' sdk: macosx @@ -113,7 +113,7 @@ parameters: packager_platform: 'macos' new_arch_enabled: '1' use_hermes: '0' - use_frameworks: '1' + use_frameworks: 'static' # - name: macos_oldarch_hermes_framework # friendly_name: 'macOS, Old Arch, Hermes, Framework' # sdk: macosx @@ -128,7 +128,7 @@ parameters: # packager_platform: 'macos' # new_arch_enabled: '1' # use_hermes: '1' - # use_frameworks: '1' + # use_frameworks: 'static' - name: ios_oldarch_jsc_framework friendly_name: 'iOS, Old Arch, JSC, Framework' sdk: iphonesimulator @@ -136,7 +136,7 @@ parameters: packager_platform: 'ios' new_arch_enabled: '0' use_hermes: '0' - use_frameworks: '1' + use_frameworks: 'static' - name: ios_newarch_jsc_framework friendly_name: 'iOS, New Arch, JSC, Framework' sdk: iphonesimulator @@ -144,7 +144,7 @@ parameters: packager_platform: 'ios' new_arch_enabled: '1' use_hermes: '0' - use_frameworks: '1' + use_frameworks: 'static' # - name: ios_oldarch_hermes_framework # friendly_name: 'iOS, Old Arch, Hermes, Framework' # sdk: iphonesimulator @@ -159,7 +159,7 @@ parameters: # packager_platform: 'ios' # new_arch_enabled: '1' # use_hermes: '1' - # use_frameworks: '1' + # use_frameworks: 'static' - name: xros_oldarch_jsc_framework friendly_name: 'xrOS, Old Arch, JSC, Framework' sdk: xrsimulator @@ -167,7 +167,7 @@ parameters: packager_platform: 'ios' new_arch_enabled: '0' use_hermes: '0' - use_frameworks: '1' + use_frameworks: 'static' - name: xros_newarch_jsc_framework friendly_name: 'xrOS, New Arch, JSC, Framework' sdk: xrsimulator @@ -175,7 +175,7 @@ parameters: packager_platform: 'ios' new_arch_enabled: '1' use_hermes: '0' - use_frameworks: '1' + use_frameworks: 'static' # - name: xros_oldarch_hermes_framework # friendly_name: 'xrOS, Old Arch, Hermes, Framework' # sdk: xrsimulator @@ -183,7 +183,7 @@ parameters: # packager_platform: 'ios' # new_arch_enabled: '1' # use_hermes: '1' - # use_frameworks: '1' + # use_frameworks: 'static' # - name: xros_newarch_hermes_framework # friendly_name: 'xrOS, New Arch, Hermes, Framework' # sdk: xrsimulator @@ -191,7 +191,7 @@ parameters: # packager_platform: 'ios' # new_arch_enabled: '1' # use_hermes: '1' - # use_frameworks: '1' + # use_frameworks: 'static' jobs: - ${{ each slice in parameters.appleBuildMatrix }}: