From 03d3b21e4cc90f0c2150516e1f3dd59f9d2d0ac7 Mon Sep 17 00:00:00 2001 From: Nick Banks Date: Tue, 30 Jul 2024 08:34:45 -0400 Subject: [PATCH 1/3] Test out a 4.0 Amplification Limit Threshold --- src/quicreach.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/quicreach.cpp b/src/quicreach.cpp index 8080341..15d1c4b 100644 --- a/src/quicreach.cpp +++ b/src/quicreach.cpp @@ -269,7 +269,7 @@ struct ReachConnection : public MsQuicConnection { MultiRtt = true; IncStat(Results.MultiRttCount); } else { - TooMuch = Amplification > 3.0; + TooMuch = Amplification > 4.0; if (TooMuch) IncStat(Results.TooMuchCount); } if (Retry) { From 6ed9f971e8cafc6f68840e56be2d0e976e084fe9 Mon Sep 17 00:00:00 2001 From: Nick Banks Date: Tue, 30 Jul 2024 08:36:54 -0400 Subject: [PATCH 2/3] Also run on PRs --- .github/workflows/reach.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/reach.yml b/.github/workflows/reach.yml index 9b22a14..6b52297 100644 --- a/.github/workflows/reach.yml +++ b/.github/workflows/reach.yml @@ -3,6 +3,8 @@ name: Reach on: push: branches: main + pull_request: + branches: main schedule: - cron: '0 */8 * * *' # every 8 hours @@ -28,6 +30,7 @@ jobs: - name: quicreach * run: /usr/local/lib/quicreach '*' --parallel 8 --stats --csv build/data.csv - name: Save results + if: github.event_name != 'pull_request' run: | git checkout data git pull From 8b4fed09efc22ff1240a405499639a156b2d5079 Mon Sep 17 00:00:00 2001 From: Nick Banks Date: Tue, 30 Jul 2024 09:05:46 -0400 Subject: [PATCH 3/3] 5x limit --- src/quicreach.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/quicreach.cpp b/src/quicreach.cpp index 15d1c4b..a2cdc23 100644 --- a/src/quicreach.cpp +++ b/src/quicreach.cpp @@ -269,7 +269,7 @@ struct ReachConnection : public MsQuicConnection { MultiRtt = true; IncStat(Results.MultiRttCount); } else { - TooMuch = Amplification > 4.0; + TooMuch = Amplification > 5.0; if (TooMuch) IncStat(Results.TooMuchCount); } if (Retry) {