Skip to content

Commit 8ff7d5e

Browse files
authored
Merge pull request #1744 from brianrob/dev/brianrob/heapdumpdll-netstandard
Build the HeapDumpDLL project for netstandard20
2 parents 672edd2 + 03a0df7 commit 8ff7d5e

File tree

4 files changed

+18
-4
lines changed

4 files changed

+18
-4
lines changed

src/Directory.Build.props

+3
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,11 @@
2323
<PropertyGroup>
2424
<!-- These are the versions of the things we are CREATING in this repository -->
2525
<FastSerializationVersion>3.0.5</FastSerializationVersion>
26+
<HeapDumpDllVersion>3.0.5</HeapDumpDllVersion>
27+
<MemoryGraphVersion>3.0.5</MemoryGraphVersion>
2628
<PerfViewVersion>3.0.5</PerfViewVersion>
2729
<TraceEventVersion>3.0.5</TraceEventVersion>
30+
<UtilitiesVersion>3.0.5</UtilitiesVersion>
2831
</PropertyGroup>
2932

3033
<!-- versions of dependencies that more than one project use -->

src/HeapDumpDLL/HeapDumpDLL.csproj

+13-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project Sdk="Microsoft.NET.Sdk">
33

44
<PropertyGroup>
5-
<TargetFrameworks>net462</TargetFrameworks>
5+
<TargetFrameworks>net462;netstandard20</TargetFrameworks>
66
<RootNamespace>Microsoft.Diagnostics.HeapDump</RootNamespace>
77
<AssemblyName>Microsoft.Diagnostics.HeapDump</AssemblyName>
88
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
@@ -11,6 +11,7 @@
1111
<Company>Microsoft</Company>
1212
<Description>General Utility library</Description>
1313
<Copyright>Copyright © Microsoft 2010</Copyright>
14+
<Version>$(HeapDumpDllVersion)</Version>
1415
</PropertyGroup>
1516

1617
<PropertyGroup>
@@ -34,19 +35,27 @@
3435
</ItemGroup>
3536

3637
<ItemGroup>
37-
<Compile Include="..\HeapDump\*.cs" />
38+
<Compile Include="..\HeapDump\GCHeapDump.cs" />
3839
<Compile Include="..\HeapDump\Utilities\*.cs" />
39-
<Compile Include="..\HeapDump\Debugger\**\*.cs" />
4040
<Compile Include="..\HeapDumpCommon\DotNetHeapInfo.cs" />
4141
<Compile Include="..\PerfView\memory\ETWClrProfilerTraceEventParser.cs" />
4242
<Compile Include="..\PerfView\memory\JavaScriptDumpGraph.cs" />
4343
<Compile Include="..\PerfView\memory\JavaScriptHeapDumper.cs" />
4444
<Compile Include="..\PerfView\PerfViewLogger.cs" />
45-
<Compile Include="..\PerfView\Triggers.cs" />
4645
<Compile Include="..\ETWHeapDump\DotNetHeapDumper.cs" />
4746
<Compile Include="..\ETWHeapDump\DotNetHeapDumpGraphReader.cs" />
4847
</ItemGroup>
4948

49+
<!-- Only include these files in the net462 version because there are some non-netstandard dependencies. -->
50+
<ItemGroup Condition="'$(TargetFramework)' == 'net462'">
51+
<Compile Include="..\HeapDump\CollectionMetadata.cs" />
52+
<Compile Include="..\HeapDump\Debugger\**\*.cs" />
53+
<Compile Include="..\HeapDump\GCHeapDumper.cs" />
54+
<Compile Include="..\HeapDump\HeapDumpException.cs" />
55+
<Compile Include="..\HeapDump\HeapDumpHResult.cs" />
56+
<Compile Include="..\PerfView\Triggers.cs" />
57+
</ItemGroup>
58+
5059
<!-- ******************* Signing Support *********************** -->
5160
<ItemGroup>
5261
<FilesToSign Include="$(TargetPath)">

src/MemoryGraph/MemoryGraph.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
<Company>Microsoft</Company>
1111
<Description>MemoryGraph library</Description>
1212
<Copyright>Copyright © Microsoft 2010</Copyright>
13+
<Version>$(MemoryGraphVersion)</Version>
1314
</PropertyGroup>
1415

1516
<ItemGroup>

src/Utilities/Utilities.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
<Company>Microsoft</Company>
1111
<Description>Utility library</Description>
1212
<Copyright>Copyright © Microsoft 2010</Copyright>
13+
<Version>$(UtilitiesVersion)</Version>
1314
</PropertyGroup>
1415

1516
<PropertyGroup>

0 commit comments

Comments
 (0)