Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenVMM Rust 2024 Compatibility #288

Open
2 of 6 tasks
smalis-msft opened this issue Nov 11, 2024 · 0 comments
Open
2 of 6 tasks

OpenVMM Rust 2024 Compatibility #288

smalis-msft opened this issue Nov 11, 2024 · 0 comments
Assignees
@smalis-msft
Labels
linting Changes for better linting and/or their cleanups

Comments

@smalis-msft
Copy link
Contributor

smalis-msft commented Nov 11, 2024 •
edited
Loading

Tracking issue for known problems that will prevent OpenVMM from adopting the Rust 2024 edition once it is released. Ideally we will fully turn on the rust-2024-compatibility lint and remove all allows before making the switch.
@smalis-msft smalis-msft mentioned this issue Nov 11, 2024
Merged
@smalis-msft smalis-msft self-assigned this Nov 12, 2024
@smalis-msft smalis-msft added the linting Changes for better linting and/or their cleanups label Nov 12, 2024
smalis-msft added a commit that referenced this issue Nov 12, 2024
@smalis-msft
Begin working towards Rust 2024 compatibility (#289)
c5a665c 
This PR fixes up the easy issues with Rust 2024 compatibility and
enables the lint for it. However it also scopes out some allows for the
things that need some more work and focus. #288 is tracking them.

Changes in this PR:

- extern blocks are now unsafe
- `gen` is becoming a reserved keyword, rename variables
- mark unsafe attributes other than linkme's
- resolve the ambiguity of `fn poll` in VmbusSerialDriver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smalis-msft smalis-msft

Labels
linting Changes for better linting and/or their cleanups
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smalis-msft