Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider running cargo-hack and cargo-unused-features in CI #251

Open
smalis-msft opened this issue Nov 6, 2024 · 1 comment
Open

Consider running cargo-hack and cargo-unused-features in CI #251

smalis-msft opened this issue Nov 6, 2024 · 1 comment
Labels
CI Improvements or additions to our CI setup outside of flowey

Comments

@smalis-msft
Copy link
Contributor

We don't really have a great story today for ensuring that our feature dependencies are 100% correct, both in terms of building crates in isolation or non-typical scenarios, and in terms of being truly minimal. There are tools out there that claim to be able to detect these cases, namely https://crates.io/crates/cargo-hack and https://crates.io/crates/cargo-unused-features (and maybe others?). I don't think running these on PR gates makes sense given their likely long runtimes over our large codebase, but maybe running them on a daily job would make sense?

@smalis-msft smalis-msft added the CI Improvements or additions to our CI setup outside of flowey label Nov 6, 2024
@smalis-msft
Copy link
Contributor Author

There's also apparently the unused-crate-dependencies lint, which can get much more precise than our current cargo-machete-ish approach, but requires actually building. Combining it with cargo-hack could be nice, but would probably take some work to get clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Improvements or additions to our CI setup outside of flowey
Projects
None yet
Development

No branches or pull requests

1 participant