Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: StandaloneMmPkg does not clear memory protections on unloaded images #1244

Open
1 task done
cfernald opened this issue Dec 12, 2024 · 0 comments
Open
1 task done
Assignees
Labels
type:bug Something isn't working urgency:high Significant with a critical impact

Comments

@cfernald
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

In StandaloneMmPkg when a binary is loaded it's code sections will be marked with the read-only memory protections. If this image then fails, it will be unloaded and its memory reclaimed. However, the core does not unset the read-only attribute and if that address is re-used later it will cause an access violation when attempting to write to the memory still marked as read-only.

Expected Behavior

The memory should be restored to the default RW so future allocations of that memory are consistent with other memory allocations.

Steps To Reproduce

Reproduction steps available internally.

Build Environment

- OS(s): N/A
- Tool Chain(s): N/A
- Targets Impacted: N/A

Version Information

2405 Release

Urgency

High

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@cfernald cfernald added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Dec 12, 2024
@github-actions github-actions bot added the urgency:high Significant with a critical impact label Dec 12, 2024
@cfernald cfernald removed their assignment Dec 12, 2024
@cfernald cfernald removed the state:needs-triage Needs to triaged to determine next steps label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working urgency:high Significant with a critical impact
Projects
None yet
Development

No branches or pull requests

2 participants