[Chat Mode]: 4 Code review agents before PR is opened

[seekdavidlee]

Chat Mode/Agent Name

Functional, Performance, Security and DotNet code review agents

Type

Chat Mode

Purpose

With HVE, we are able to generate thousands of lines of code, and it is not possible to inspect every line of code. Before a dev creates a PR, it would be important for the dev to run through an initial code review. Each code review agent specializes in a specific area and will provide important guidance on areas to fix.

Requirements

1. Issues are numbered and are ordered by severity
2. Issues must indicate the line numbers and code snippet of the original code and proposed changes.
3. The specific agent MUST only check for branch diff and not any other areas

The dev can now selectively specify a numbered issue to fix. If there are mcp integration with work tracking such as Jira, the dev can also create backlog items.

[WilliamBerryiii]

@seekdavidlee ... how does this intersect with https://github.com/microsoft/hve-core/blob/main/.github/chatmodes/pr-review.chatmode.md?

[seekdavidlee]

Hi @WilliamBerryiii, appreciate the quick response!

Looking at the pr-review chatmode, I do see functional, performance and security code reviews covered but not a specialize one for .NET. My use case is for before you are ready to submit a PR, you can use these 4 separates and specialized chatmodes to generate local md files for each area individually and you can iterate on quickly without the full review yet. Of course, the devs are also using this for the final PR as well so it intersects at that point. The report is very similar but less detailed (no user decision or follow up notes). This is a snippet.

For each issue identified, provide feedback in this exact format:

## Issue {number}: [Brief descriptive title]

**Priority**: Critical/High/Medium/Low
**Category**: Modern C# | Performance | Conventions | Architecture
**File**: `path/to/file.cs`
**Lines**: 45-52

### Problem
[Specific description of what's wrong with the current code]

### Current Code
...csharp
[Exact code from the diff that has the issue]
...

### Suggested Solution
...csharp
[Exact replacement code that fixes the issue using modern .NET practices]

I could see the pr-review chatmode doing everything all at once for my use case. My hypothesis is that having specialize chatmodes looking at individual area is going to be more effective and targeted (given a more specific context) but of course, for our engagement, we have only been using these 4 specialized chatmodes for the last 2 months and did not have the chance to look at the pr-review chatmode.

[WilliamBerryiii]

@agreaves-ms - I think this fits nicely with what we were chatting about today with pre-packaged "toolkits" ... I think it makes sense for us to review @eedorenko's most recent contribution to reorganize the whole suite of prompts, chatmodes, agents, and instructions to enable scenarios like this.

@seekdavidlee - hang tight on this for a bit while we try to spike on an idea that would enable this capability in a pretty seamless fashion. We'll get it started with the Edge-AI language toolkits and then will reply back with some instructions for other languages ... Like your approach here (and sorry for the holiday delay in getting back to you ... I need some time off before I got back to the grindstone 😂)