This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Fix duplicate bytes #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24
The logic which checks if content exceeds the block max has a bug where the last byte is sent again.
In a simpler form the bug is just:
x = 'test'
x[0..2] is 'tes'
x[2..] is 'st'
I think this never caused an issue with max len buffers because the constant subtracts 1, so there's room in the request to send that extra byte.
I applied this fix and ran the test described in #24 and the blob contents match the text file.
I also added some tests for this area.