Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluent-bit to 3.1.9 and allow lua plugin #10690

Closed
wants to merge 3 commits into from

Conversation

paulmey
Copy link
Member

@paulmey paulmey commented Oct 10, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

PR Description

Enabled the lua filter plugin which was previously disabled because it pulled in a copy of the luajit library, which it wanted to install.
fluent/fluent-bit#7286 (in 3.1.5) makes it possible to use the system luajit library instead of the vendored version.
With this change, the lua filter plugin can be built with the system luajit library.

Also, according to https://fluentbit.io/announcements/older-versions/, the 3.0 line went EOL on Sep 11 2024.

Test Methodology
  • Fix verification
    • Tested local RPM build with %with_check=1
    • Impacted user verification - xxxx
  • Package Tests
    • Package build & ptest - xxxx
    • Upgrade/downgrade test - xxxx
  • Scenario Test results (or explain why the scenario does not need to be tested)
    • AKS: xxxx
    • Azure VM: xxxx
    • BVT: xxxx
    • BareMetal: xxxx
    • ISO: xxxx
    • Container: xxxx
Regression Risk

To the best of your knowledge, where might potential problems/regressions arise?

According to Upgrade Notes | Fluent Bit: Official Manual, there have not been any breaking changes for a long time. None of the release notes between 3.0.6 and 3.1.9 mention any breaking changes either.

Does this affect the toolchain?

NO

Relevant links

@paulmey
Copy link
Member Author

paulmey commented Oct 10, 2024

Need help getting the sources uploaded to https://azurelinuxsrcstorage.blob.core.windows.net/sources/core/fluent-bit-3.1.9.tar.gz

@paulmey paulmey requested review from a team as code owners October 11, 2024 07:46
@paulmey paulmey changed the base branch from 3.0 to 3.0-dev October 11, 2024 07:47
@paulmey paulmey requested a review from a team as a code owner October 11, 2024 07:47
@paulmey
Copy link
Member Author

paulmey commented Oct 11, 2024

Need help getting the sources uploaded to https://azurelinuxsrcstorage.blob.core.windows.net/sources/core/fluent-bit-3.1.9.tar.gz

@mfrw, can you help with this?

@paulmey paulmey requested a review from mfrw October 12, 2024 11:49
@eric-desrochers
Copy link
Contributor

eric-desrochers commented Nov 1, 2024

[Stable Maintainer note]
fluent-bit bump approved on 10/31 by the stable maintainer team. We will wait until all relevant approvers review the PR, then we (CBL-Mariner-Stable-Maintainers) will provide final review.

@dmcilvaney dmcilvaney mentioned this pull request Nov 11, 2024
12 tasks
@eric-desrochers
Copy link
Contributor

Closing this PR in favor of #11009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable lua filter for fluent-bit
3 participants