Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Commit 19b2419

Browse files
committed
Blank info messages. Give them a message. This whole messaging situation needs a little thought.
1 parent b6df226 commit 19b2419

3 files changed

+8
-8
lines changed

DisplayClassAllocationAnalyzer.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
[DiagnosticAnalyzer(LanguageNames.CSharp)]
1414
public sealed class DisplayClassAllocationAnalyzer : ISyntaxNodeAnalyzer<SyntaxKind>
1515
{
16-
internal static DiagnosticDescriptor ClosureDriverRule = new DiagnosticDescriptor("HeapAnalyzerClosureSourceRule", "Closure Allocation Source", "Captures: {0}", "Performance", DiagnosticSeverity.Warning, true);
16+
internal static DiagnosticDescriptor ClosureDriverRule = new DiagnosticDescriptor("HeapAnalyzerClosureSourceRule", "Closure Allocation Source", "Heap allocation of closure Captures: {0}", "Performance", DiagnosticSeverity.Warning, true);
1717

1818
internal static DiagnosticDescriptor ClosureCaptureRule = new DiagnosticDescriptor("HeapAnalyzerClosureCaptureRule", "Display class allocation to capture closure", "The compiler will emit a class that will hold this as a field to allow capturing of this closure", "Performance", DiagnosticSeverity.Warning, true);
1919

EnumeratorAllocationAnalyzer.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
[DiagnosticAnalyzer(LanguageNames.CSharp)]
1212
public sealed class EnumeratorAllocationAnalyzer : ISyntaxNodeAnalyzer<SyntaxKind>
1313
{
14-
internal static DiagnosticDescriptor ReferenceTypeEnumeratorRule = new DiagnosticDescriptor("HeapAnalyzerEnumeratorAllocationRule", "Reference type enumerator, possible allocation", "Enumerator is not of a value type, and so it is possible that this results in an enumerator allocation", "Performance", DiagnosticSeverity.Warning, true);
14+
internal static DiagnosticDescriptor ReferenceTypeEnumeratorRule = new DiagnosticDescriptor("HeapAnalyzerEnumeratorAllocationRule", "Possible allocation of reference type enumerator", "Non-ValueType enumerator may result in an heap allocation", "Performance", DiagnosticSeverity.Warning, true);
1515

1616
internal static object[] EmptyMessageArgs = { };
1717

ExplicitAllocationAnalyzer.cs

+6-6
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@
1111
[DiagnosticAnalyzer(LanguageNames.CSharp)]
1212
public sealed class ExplicitAllocationAnalyzer : ISyntaxNodeAnalyzer<SyntaxKind>
1313
{
14-
internal static DiagnosticDescriptor NewArrayRule = new DiagnosticDescriptor("HeapAnalyzerExplicitNewArrayRule", "Explicit new array type allocation", string.Empty, "Performance", DiagnosticSeverity.Info, true);
14+
internal static DiagnosticDescriptor NewArrayRule = new DiagnosticDescriptor("HeapAnalyzerExplicitNewArrayRule", "Explicit new array type allocation", "Explicit new array type allocation", "Performance", DiagnosticSeverity.Info, true);
1515

16-
internal static DiagnosticDescriptor NewObjectRule = new DiagnosticDescriptor("HeapAnalyzerExplicitNewObjectRule", "Explicit new reference type allocation", string.Empty, "Performance", DiagnosticSeverity.Info, true);
16+
internal static DiagnosticDescriptor NewObjectRule = new DiagnosticDescriptor("HeapAnalyzerExplicitNewObjectRule", "Explicit new reference type allocation", "Explicit new reference type allocation", "Performance", DiagnosticSeverity.Info, true);
1717

18-
internal static DiagnosticDescriptor AnonymousNewObjectRule = new DiagnosticDescriptor("HeapAnalyzerExplicitNewAnonymousObjectRule", "Explicit new anonymous object allocation", string.Empty, "Performance", DiagnosticSeverity.Info, true, string.Empty, "http://msdn.microsoft.com/en-us/library/bb397696.aspx");
18+
internal static DiagnosticDescriptor AnonymousNewObjectRule = new DiagnosticDescriptor("HeapAnalyzerExplicitNewAnonymousObjectRule", "Explicit new anonymous object allocation", "Explicit new anonymous object allocation", "Performance", DiagnosticSeverity.Info, true, string.Empty, "http://msdn.microsoft.com/en-us/library/bb397696.aspx");
1919

20-
internal static DiagnosticDescriptor ImplicitArrayCreationRule = new DiagnosticDescriptor("HeapAnalyzerImplicitNewArrayCreationRule", "Implicit new array creation allocation", string.Empty, "Performance", DiagnosticSeverity.Info, true);
20+
internal static DiagnosticDescriptor ImplicitArrayCreationRule = new DiagnosticDescriptor("HeapAnalyzerImplicitNewArrayCreationRule", "Implicit new array creation allocation", "Implicit new array creation allocation", "Performance", DiagnosticSeverity.Info, true);
2121

22-
internal static DiagnosticDescriptor InitializerCreationRule = new DiagnosticDescriptor("HeapAnalyzerInitializerCreationRule", "Initializer reference type allocation", string.Empty, "Performance", DiagnosticSeverity.Info, true);
22+
internal static DiagnosticDescriptor InitializerCreationRule = new DiagnosticDescriptor("HeapAnalyzerInitializerCreationRule", "Initializer reference type allocation", "Initializer reference type allocation", "Performance", DiagnosticSeverity.Info, true);
2323

24-
internal static DiagnosticDescriptor LetCauseRule = new DiagnosticDescriptor("HeapAnalyzerLetClauseRule", "Let clause induced allocation", string.Empty, "Performance", DiagnosticSeverity.Info, true);
24+
internal static DiagnosticDescriptor LetCauseRule = new DiagnosticDescriptor("HeapAnalyzerLetClauseRule", "Let clause induced allocation", "Let clause induced allocation", "Performance", DiagnosticSeverity.Info, true);
2525

2626
internal static object[] EmptyMessageArgs = { };
2727

0 commit comments

Comments
 (0)