-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does Bitnet support ROCm testing? #281
Comments
@ym-guan Thank you for reporting this. We’ve recently migrated the backend from tensorir to tilelang. While we do plan to support ROCm and CDNA with matrix code and already have implementations, it isn’t migrated yet. I’ll work on adding this as soon as possible, though I am currently juggling two upcoming deadlines, I'll take a look on this next week. |
@ym-guan Btw, I noticed that you’ve made some great modifications to support ROCm—awesome work! It looks like the bug might be in this section, where the kernel builder is dispatched to CUDA instead of HIP in certain places. Feel free to ask any questions :) |
Thank you @LeiWang1999 ! I follow your instruction and modified the code more. Actually, I support the matrix code https://github.com/microsoft/BitBLAS/blob/main/testing/python/amd/test_backend_hip_wrapper_matmul.py#L54, However, it doesn't support "matmul_backend_code_wrap(1, 256, 256, "float16", "float16", "uint4", "float16", False)" This is because the scheduler_ir_module cannot be tl.lower() correctly https://github.com/microsoft/BitBLAS/blob/main/bitblas/ops/operator.py#L195, it told me I guess the MatmulDequantizeScheduler cannot be transfer into hip correctly. If it can be, please correct me. In a word, when I test matmul with config like int8xint2, I got the error
But it should be compile through hip, how? Thanks for your reply! |
pr #282 made a simple fix, but only support target inference and consistent matmul (A and W are in the same datatypes), with dequantize may take few days to implement. |
Hi Lei, I'm trying to reproduce bitnet result with Mi308, But I meet some errors.
I use main branch to run and error like this
I'm trying to modify the code to support ROCm like this:
unfortunately I failed, it told me
I guess there is no scheduler func for Mi308 in backend tl.
So, I checkout branch "amd_hip", run , and I found error
In this branch, which use backend tir, there is a lot differences between branch "amd_hip" and "main". I have two Question: Does backend tl support ROCm? Does Bitnet support testing in ROCm?
Please tell me how to test bitnet in ROCm, thx!
My system
The text was updated successfully, but these errors were encountered: