Fix lint errors and address code review feedback

- Remove trailing whitespace (auto-formatted with ruff)
- Add validation for malformed URLs like "http:8080" (missing slashes)
- Update comment to clarify "domain with optional port" instead of "just a domain"
- Add tests for malformed URL edge cases
- All 30 tests passing

Co-authored-by: nikhilNava <[email protected]>

Author: Copilot

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter.py

@@ -95,13 +95,13 @@ def export(self, spans: Sequence[ReadableSpan]) -> SpanExportResult:
                 else:
                     discovery = PowerPlatformApiDiscovery(self._cluster_category)
                     endpoint = discovery.get_tenant_island_cluster_endpoint(tenant_id)
-                
+
                 endpoint_path = (
                     f"/maven/agent365/service/agents/{agent_id}/traces"
                     if self._use_s2s_endpoint
                     else f"/maven/agent365/agents/{agent_id}/traces"
                 )
-                
+
                 # Construct URL - if endpoint has a scheme (http:// or https://), use it as-is
                 # Otherwise, prepend https://
                 # Note: Check for "://" to distinguish between real protocols and domain:port format

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/utils.py

@@ -157,7 +157,7 @@ def get_validated_domain_override() -> str | None:
     # Validate that it's a valid URL
     try:
         parsed = urlparse(domain_override)
-        
+
         # If scheme is present and looks like a protocol (contains //)
         # Note: We check for "://" because urlparse treats "example.com:8080" as having
         # scheme="example.com", but this is actually a domain with port, not a protocol.
@@ -171,14 +171,18 @@ def get_validated_domain_override() -> str | None:
                 return None
             # Must have a netloc (hostname) when scheme is present
             if not parsed.netloc:
+                logger.warning(f"Invalid domain override '{domain_override}': missing hostname")
+                return None
+        else:
+            # If no scheme with ://, it should be a domain with optional port (no path)
+            # Note: domain can contain : for port (e.g., example.com:8080)
+            # Reject malformed URLs like "http:8080" that look like protocols but aren't
+            if domain_override.startswith(("http:", "https:")) and "://" not in domain_override:
                 logger.warning(
                     f"Invalid domain override '{domain_override}': "
-                    "missing hostname"
+                    "malformed URL - protocol requires '://'"
                 )
                 return None
-        else:
-            # If no scheme with ://, it should be just a domain (no path)
-            # Note: domain can contain : for port (e.g., example.com:8080)
             if "/" in domain_override:
                 logger.warning(
                     f"Invalid domain override '{domain_override}': "

tests/observability/core/exporters/test_utils.py

@@ -101,9 +101,7 @@ def test_accepts_valid_domain_with_port(self):
 
     def test_accepts_valid_https_url(self):
         """Test that function accepts a valid URL with https protocol."""
-        with patch.dict(
-            os.environ, {"A365_OBSERVABILITY_DOMAIN_OVERRIDE": "https://example.com"}
-        ):
+        with patch.dict(os.environ, {"A365_OBSERVABILITY_DOMAIN_OVERRIDE": "https://example.com"}):
             result = get_validated_domain_override()
             self.assertEqual(result, "https://example.com")
 
@@ -123,17 +121,13 @@ def test_accepts_valid_http_url_with_port(self):
 
     def test_rejects_invalid_protocol(self):
         """Test that function rejects URLs with invalid protocols (not http/https)."""
-        with patch.dict(
-            os.environ, {"A365_OBSERVABILITY_DOMAIN_OVERRIDE": "ftp://example.com"}
-        ):
+        with patch.dict(os.environ, {"A365_OBSERVABILITY_DOMAIN_OVERRIDE": "ftp://example.com"}):
             result = get_validated_domain_override()
             self.assertIsNone(result)
 
     def test_rejects_domain_with_path(self):
         """Test that function rejects domain-only format with path separator."""
-        with patch.dict(
-            os.environ, {"A365_OBSERVABILITY_DOMAIN_OVERRIDE": "example.com/path"}
-        ):
+        with patch.dict(os.environ, {"A365_OBSERVABILITY_DOMAIN_OVERRIDE": "example.com/path"}):
             result = get_validated_domain_override()
             self.assertIsNone(result)
 
@@ -143,6 +137,18 @@ def test_rejects_protocol_without_hostname(self):
             result = get_validated_domain_override()
             self.assertIsNone(result)
 
+    def test_rejects_malformed_url_http_colon(self):
+        """Test that function rejects malformed URLs like 'http:8080' (missing slashes)."""
+        with patch.dict(os.environ, {"A365_OBSERVABILITY_DOMAIN_OVERRIDE": "http:8080"}):
+            result = get_validated_domain_override()
+            self.assertIsNone(result)
+
+    def test_rejects_malformed_url_https_colon(self):
+        """Test that function rejects malformed URLs like 'https:443' (missing slashes)."""
+        with patch.dict(os.environ, {"A365_OBSERVABILITY_DOMAIN_OVERRIDE": "https:443"}):
+            result = get_validated_domain_override()
+            self.assertIsNone(result)
+
 
 if __name__ == "__main__":
     unittest.main()