Skip to content

Commit 10b220d

Browse files
resolve comments
1 parent 34a668b commit 10b220d

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ async def add_tool_servers_to_agent(
7979
# Create the agent with all tools (initial + MCP tools)
8080
all_tools = list(initial_tools)
8181

82-
# Add MCP plugins for each server config
82+
# Add servers as MCPStreamableHTTPTool instances
8383
for config in server_configs:
8484
try:
8585
server_url = getattr(config, "server_url", None) or getattr(
@@ -100,7 +100,7 @@ async def add_tool_servers_to_agent(
100100

101101
server_name = getattr(config, "mcp_server_name", "Unknown")
102102

103-
# Create and configure MCP plugin
103+
# Create and configure MCPStreamableHTTPTool
104104
mcp_tools = MCPStreamableHTTPTool(
105105
name=server_name,
106106
url=server_url,
@@ -135,7 +135,7 @@ async def add_tool_servers_to_agent(
135135

136136
except Exception as ex:
137137
self._logger.error(f"Failed to add tool servers to agent: {ex}")
138-
return None
138+
raise
139139

140140
async def cleanup(self):
141141
"""Clean up any resources used by the service."""

libraries/microsoft-agents-a365-tooling-extensions-agentframework/setup.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
# Copyright (c) Microsoft Corporation.
2-
# Licensed under the MIT License.
1+
# Copyright (c) Microsoft. All rights reserved.
32

43
import os
54
from datetime import datetime
@@ -28,4 +27,4 @@ def build_version():
2827

2928
setup(
3029
version=VERSION,
31-
)
30+
)

0 commit comments

Comments
 (0)