Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#421] UserDetails Member도메인에서 분리 #422

Merged
merged 5 commits into from
Jan 7, 2024
Merged

[#421] UserDetails Member도메인에서 분리 #422

merged 5 commits into from
Jan 7, 2024

Conversation

gkfktkrh153
Copy link
Member

@gkfktkrh153 gkfktkrh153 commented Jan 7, 2024 •
edited
Loading

Issue

Issue 내용

  • User를 상속받은 이유는 폼로그인 과정의 loadByUsername메서드에서 사용하기 위함인데 이 하나의 과정을 위해 굳이 User를 상속받을 이유가 없다 판단하여 분리합니다.
  • 이제부터 해당 메서드를 사용하는 부분에서는 따로 UserDetails(User)를 상속받은 클래스를 만들어 사용합니다.

this closed #421

@gkfktkrh153 gkfktkrh153 self-assigned this Jan 7, 2024
angelSuho
angelSuho approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@angelSuho angelSuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카카오톡 로그인 로직 확인하였습니다. 고생하셨습니다

@angelSuho angelSuho merged commit a0e4862 into development Jan 7, 2024
@angelSuho angelSuho deleted the refactoring/421-user branch January 7, 2024 15:32
@angelSuho angelSuho changed the title UserDetails Member도메인에서 분리 [#421] UserDetails Member도메인에서 분리 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelSuho angelSuho angelSuho approved these changes

@Abbbyy Abbbyy Awaiting requested review from Abbbyy Abbbyy is a code owner

Assignees

@gkfktkrh153 gkfktkrh153

Labels
♻️ Refactor
Projects
millicon
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Member - UserDetails 분리
2 participants
@gkfktkrh153 @angelSuho