Merge pull request #207 from miIlicon/bugFix/207-bulkInsert

[#207] id매칭 하드코딩 제거
miIlicon · Sep 14, 2023 · 9587d47 · 9587d47
2 parents 0069dd1 + 79e6b7c
commit 9587d47
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/main/java/com/festival/common/data/Data.java b/src/main/java/com/festival/common/data/Data.java
@@ -34,10 +34,10 @@ CommandLineRunner initData(
             if (initDataDone) return;
 
             initDataDone = true;
-            memberService.join(MemberJoinReq.of("user", "1234", "ADMIN"));
-            imageRepository.save(Image.builder()
+            Long memberId = memberService.join(MemberJoinReq.of("user", "1234", "ADMIN"));
+            Long imageId = imageRepository.save(Image.builder()
                     .mainFilePath("")
-                    .subFilePaths(List.of("")).build());
+                    .subFilePaths(List.of("")).build()).getId();
 
             int cnt = 1;
             long start = System.currentTimeMillis();
@@ -54,8 +54,8 @@ CommandLineRunner initData(
                             .longitude(50L)
                             .latitude(50L)
                             .type("PUB")
-                            .imageId(1L)
-                            .memberId(1L)
+                            .imageId(imageId)
+                            .memberId(memberId)
                             .lastModifiedBy("user")
                             .createdBy("user")
                             .build());

diff --git a/src/main/java/com/festival/domain/member/service/MemberService.java b/src/main/java/com/festival/domain/member/service/MemberService.java
@@ -36,12 +36,12 @@ public class MemberService {
     private final AuthenticationManagerBuilder authenticationManagerBuilder;
 
     @Transactional
-    public void join(MemberJoinReq memberJoinReq) {
+    public Long join(MemberJoinReq memberJoinReq) {
         if (isLoginIdSave(memberJoinReq.getUsername())) {
             throw new DuplicationException(DUPLICATION_ID);
         }
         Member member = Member.of(memberJoinReq, passwordEncoder.encode(memberJoinReq.getPassword()));
-        Member savedMember = memberRepository.save(member);
+        return memberRepository.save(member).getId();
     }
 
     public JwtTokenRes login(MemberLoginReq loginReq) {