Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer javascript load #109

Open
chrisjsewell opened this issue Feb 21, 2023 · 2 comments
Open

Defer javascript load #109

chrisjsewell opened this issue Feb 21, 2023 · 2 comments

Comments

@chrisjsewell
Copy link

Heya, at the moment the javascript load blocks the initial page render.

This is acutely problematic, if for example unpkg.com is being slow, as I just experienced in the MyST documentation 😒

You need to add the loading_method="defer":
https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx.application.Sphinx.add_js_file

You then need to account for this in the initialisation, something like:

window.onload = function () {mermaid.initialize({startOnLoad:true})}

Ideally even, I see that you use html-page-context to load the JS, but here you should also only load it on pages where mermaid is actually used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants