File tree 4 files changed +19
-5
lines changed
lib/metric_fu/metrics/flay
spec/metric_fu/metrics/flay
4 files changed +19
-5
lines changed Original file line number Diff line number Diff line change @@ -7,8 +7,7 @@ def self.metric
7
7
end
8
8
9
9
def emit
10
- minimum_score_parameter = options [ :minimum_score ] ? "--mass #{ options [ :minimum_score ] } " : ""
11
- args = "#{ minimum_score_parameter } #{ options [ :dirs_to_flay ] . join ( " " ) } "
10
+ args = "#{ minimum_duplication_mass } #{ dirs_to_flay } "
12
11
@output = run! ( args )
13
12
end
14
13
@@ -29,5 +28,20 @@ def to_h
29
28
end
30
29
{ :flay => { :total_score => total_score , :matches => target . flatten } }
31
30
end
31
+
32
+ private
33
+
34
+ def minimum_duplication_mass
35
+ flay_mass = options [ :minimum_score ]
36
+ return "" unless flay_mass
37
+
38
+
39
+ "--mass #{ flay_mass } "
40
+ end
41
+
42
+ def dirs_to_flay
43
+ options [ :dirs_to_flay ] . join ( " " )
44
+ end
45
+
32
46
end
33
47
end
Original file line number Diff line number Diff line change @@ -11,7 +11,7 @@ def default_run_options
11
11
# a long time. This is a really big number, considering
12
12
# the default is 16. Setting it to nil to use the Flay default.
13
13
:minimum_score => nil ,
14
- :filetypes => [ 'rb' ] }
14
+ }
15
15
end
16
16
17
17
def has_graph?
Original file line number Diff line number Diff line change 7
7
it 'should set @flay to {:dirs_to_flay => @code_dirs}' do
8
8
load_metric 'flay'
9
9
expect ( MetricFu ::Metric . get_metric ( :flay ) . run_options ) . to eq (
10
- { :dirs_to_flay => [ 'lib' ] , :filetypes => [ "rb" ] , : minimum_score=> nil }
10
+ { :dirs_to_flay => [ 'lib' ] , :minimum_score => nil }
11
11
)
12
12
end
13
13
Original file line number Diff line number Diff line change 4
4
describe MetricFu ::FlayGenerator do
5
5
describe "emit method" do
6
6
it "should look at the dirs" do
7
- options = { :dirs_to_flay => [ 'app' , 'lib' ] , :filetypes => [ 'rb' ] }
7
+ options = { :dirs_to_flay => [ 'app' , 'lib' ] }
8
8
allow ( File ) . to receive ( :directory? ) . and_return ( true )
9
9
@flay = MetricFu ::FlayGenerator . new ( options )
10
10
You can’t perform that action at this time.
0 commit comments