Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Allow Options Parameter After Pipeline #22

Open
sotarules opened this issue Jul 22, 2015 · 2 comments
Open

Enhancement Request: Allow Options Parameter After Pipeline #22

sotarules opened this issue Jul 22, 2015 · 2 comments

Comments

@sotarules
Copy link

Enhancement request: allow the caller to supply second-positional-parameter options. I saw that there was an earlier request for this feature specifically to enable allowDiskUse, which you mentioned would not work. I have more modest need: to enable explain.

I have hacked together a custom solution on my system:

explainResults = Meteor.wrapAsync(collection.rawCollection().aggregate.bind(collection.rawCollection()))(pipeline, { explain: true });

This seems to work, I'm getting back helpful explain results.

This could be a low-cost/low-risk change that would improve utility of this package. IMHO explain results can be quite helpful when developing complex aggregate queries.

@arunoda
Copy link
Member

arunoda commented Jul 23, 2015

Would you mind send me a PR?

On Thu, Jul 23, 2015 at 3:24 AM David Lynch [email protected]
wrote:

Enhancement request: allow the caller to supply
second-positional-parameter options. I saw that there was an earlier
request for this feature specifically to enable allowDiskUse, which you
mentioned would not work. I have more modest need: to enable explain.

I have hacked together a custom solution on my system:

explainResults = Meteor.wrapAsync(collection.rawCollection().aggregate.bind(collection.rawCollection()))(pipeline, { explain: true });

This seems to work, I'm getting back helpful explain results.

This could be a low-cost/low-risk change that would improve utility of
this package. IMHO explain results can be quite helpful when developing
complex aggregate queries.


Reply to this email directly or view it on GitHub
#22.

@sotarules
Copy link
Author

Arunoda,

Please bear with me, because I don’t do many of these pull requests:

https://github.com/sotarules/meteor-aggregate/pull/1

I think this is right. I tried the code locally and it seems to work.

Best regards,

Dave

David Lynch

Software Engineer

SOTA New Minimal 200 X 100

SOTA Enterprises, Inc.

690 South La Luna Avenue
Ojai, California 93023
Voice 805-640-1212 Skype 805-633-1225

From: Arunoda Susiripala [mailto:[email protected]]
Sent: Wednesday, July 22, 2015 5:54 PM
To: meteorhacks/meteor-aggregate
Cc: David Lynch
Subject: Re: [meteor-aggregate] Enhancement Request: Allow Options Parameter After Pipeline (#22)

Would you mind send me a PR?

On Thu, Jul 23, 2015 at 3:24 AM David Lynch [email protected]
wrote:

Enhancement request: allow the caller to supply
second-positional-parameter options. I saw that there was an earlier
request for this feature specifically to enable allowDiskUse, which you
mentioned would not work. I have more modest need: to enable explain.

I have hacked together a custom solution on my system:

explainResults = Meteor.wrapAsync(collection.rawCollection().aggregate.bind(collection.rawCollection()))(pipeline, { explain: true });

This seems to work, I'm getting back helpful explain results.

This could be a low-cost/low-risk change that would improve utility of
this package. IMHO explain results can be quite helpful when developing
complex aggregate queries.


Reply to this email directly or view it on GitHub
#22.


Reply to this email directly or view it on GitHub #22 (comment) . https://github.com/notifications/beacon/AFM5nxF6aapolCJsXg7OUTIue3TTbmU0ks5ogDK7gaJpZM4Fd9DP.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants