-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template exceptions are using console.log not console.error #314
Comments
Although this sounds like a reasonable change to Blaze it could cause side effects on legacy apps. |
We could also add this new feature as an option, like log levels. Like on We could have something like: "packages": {
"blaze": {
"logLevel": {
"error": "error"
}
}
} and in this case the default would be and not requiring any setting. "logLevel": {
"error": "info"
} |
Hi, as we are not having many discussions around this issue I'm closing it. Of course, if we have new ideas or problems we can re-open it. No problem. |
Hi @filipenevola sorry I didn't come back on your suggestion, it was simply because I thought it was a final proposal and I agreed 100% :) Ultimately our only option to get visibility on critical issues happening in our app today (via Sentry.io for example) will be to monkey patch the log handling as suggested by @softwarerero which leaves me concerned about unexpected future breakages and unexpected behaviour. Having first class logger support and options like you have suggested would be amazing |
A similar annoyance for the community is the way Method callbacks squash exceptions that are rethrown as well : https://forums.meteor.com/t/sentry-raven-with-meteor-on-server/32383/20 If you are planning improvements, recommend looking at what you can do here too |
Maybe we could utilize the |
We dont see template exceptions bubble up into our unhandled exception handler (Sentry) because Blaze catches them and reports to console as info, instead of as error.
Equally what if I want my app to fail fast on any template error instead of continuing in a broken state? This is not possible because blaze doesn't have option to rethrow/bubble up unhandled?
We're using Meteor 1.10.1
The text was updated successfully, but these errors were encountered: