Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if (props) ... #28

Open
comerc opened this issue May 1, 2016 · 2 comments
Open

if (props) ... #28

comerc opened this issue May 1, 2016 · 2 comments
Assignees
@DominikGuzei
Labels
enhancement

Comments

@comerc
Copy link
Contributor

comerc commented May 1, 2016

It look strange
@DominikGuzei
Copy link
Member

Haha, why strange? this just checks if the props value from the config is a truthy value … but you're right, i could make it more explicit by checking if it is actually an object.

@DominikGuzei DominikGuzei self-assigned this May 2, 2016
@comerc
Copy link
Contributor Author

comerc commented May 2, 2016 •
edited
Loading

From readme:

You can pass any object to the props option, which provides a clean and validate function.

we need check: if (props is object) and (props.validate is function) and (props.clean is function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominikGuzei DominikGuzei

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DominikGuzei @comerc