Skip to content

Commit 1fc211b

Browse files
Add option to list all fw-sets (#24)
By default mctl list firmware-sets will list only firmware sets containing labels for vendor, model and latest=true. This change adds a --all option to list all sets without any filters
1 parent 5b4b154 commit 1fc211b

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

cmd/list/firmware_set.go

+17-5
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,14 @@ import (
1010
"github.com/metal-toolbox/mctl/pkg/model"
1111
"github.com/olekukonko/tablewriter"
1212
"github.com/spf13/cobra"
13+
14+
serverservice "go.hollow.sh/serverservice/pkg/api/v1"
1315
)
1416

1517
type listFirmwareSetFlags struct {
16-
vendor string
17-
model string
18+
vendor string
19+
model string
20+
listAll bool
1821
}
1922

2023
var (
@@ -33,9 +36,17 @@ var listFirmwareSet = &cobra.Command{
3336
log.Fatal(err)
3437
}
3538

36-
fwSet, err := mctl.FirmwareSetByVendorModel(cmd.Context(), flagsDefinedListFwSet.vendor, flagsDefinedListFwSet.model, client)
37-
if err != nil {
38-
log.Fatal(err)
39+
var fwSet []serverservice.ComponentFirmwareSet
40+
if flagsDefinedListFwSet.listAll {
41+
fwSet, _, err = client.ListServerComponentFirmwareSet(cmd.Context(), &serverservice.ComponentFirmwareSetListParams{})
42+
if err != nil {
43+
log.Fatal(err)
44+
}
45+
} else {
46+
fwSet, err = mctl.FirmwareSetByVendorModel(cmd.Context(), flagsDefinedListFwSet.vendor, flagsDefinedListFwSet.model, client)
47+
if err != nil {
48+
log.Fatal(err)
49+
}
3950
}
4051

4152
if outputJSON {
@@ -69,4 +80,5 @@ func init() {
6980

7081
listFirmwareSet.PersistentFlags().StringVar(&flagsDefinedListFwSet.vendor, "vendor", "", "filter by server vendor")
7182
listFirmwareSet.PersistentFlags().StringVar(&flagsDefinedListFwSet.model, "model", "", "filter by server model")
83+
listFirmwareSet.PersistentFlags().BoolVar(&flagsDefinedListFwSet.listAll, "all", false, "show all firmware sets. By default results are filtered on having labels for vendor, model and latest=true")
7284
}

0 commit comments

Comments
 (0)