Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong name sign nuget release #18

Open
GieltjE opened this issue Nov 11, 2016 · 4 comments
Open

Strong name sign nuget release #18

GieltjE opened this issue Nov 11, 2016 · 4 comments

Comments

@GieltjE
Copy link

GieltjE commented Nov 11, 2016

This helps with verifying releases and unsigned assemblies cannot be loaded when products are released.

@samwierema
Copy link
Contributor

Thanks for opening an issue @GieltjE! I've never considered this, but this is indeed an issue when you want to reference our package in your strongly named package.

I'll discuss with the team how best to proceed (not sure how it works for open source projects) and get back to you in the next week.

@GieltjE
Copy link
Author

GieltjE commented Nov 11, 2016

Thanks for considering it, as far as I know there are no downsides to signing it, just keep your key private (e.g. adding it to the git ignores is a good start).

For now I just added your code to our project

@GieltjE
Copy link
Author

GieltjE commented Dec 6, 2016

Any progress?

@samwierema
Copy link
Contributor

@GieltjE no progress at this time, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants