Skip to content

Commit 80fc0f2

Browse files
nebmanthebenternjp-bennettGUVWAFfifieldt
authored
Detect charging status by measuring current flow with configured INA battery sensor (#5271)
* INA219 charging detection minimal implementation: if there is a configured INA219 sensor for battery monitoring we can take the current flow across the shunt resistor to know if we are charging the battery - negative milliamps indicate charging * Update Power.cpp added comments and 2 extra defines to disable and swap detection direction * Update Power.cpp fix disabled case * move getCurrentMa() to new CurrentSensor class * INA219 charging detection minimal implementation: if there is a configured INA219 sensor for battery monitoring we can take the current flow across the shunt resistor to know if we are charging the battery - negative milliamps indicate charging * Update Power.cpp added comments and 2 extra defines to disable and swap detection direction * Update Power.cpp fix disabled case * move getCurrentMa() to new CurrentSensor class * add INA3221 charging detection * RP2040: Update core; add mDNS support (#5355) * Update arduino-pico core * RP2040: Add mDNS support * SimpleMDNS `begin` now returns a bool * Add `-g` option to `debug_build_flags` to link files for gdb * RAK11310 needs old platform as well * Change defines to specific architecture * Core version 4.2.1 is out * Add sudo to apt-get commands for Raspbian Build (#5364) Without sudo, inadequate permissions to runs the commands meant the build was failing. * Typo fix in build_raspbian.yml (#5365) s/sudp/sudo :(:(:( * Rework some things * Trunk * Separate littlefs bundle * version tags * Diag * Add littlefswebui * Bug fixed in ExternalNotificationModule (#5375) While `nagging` setExternalState wasn't written to Buzzer & Vibra so output was never toggled. Possible fix for #5348 * Cleanup static files from bad Web UI bundle on 2.5.13 release (#5376) * Cleanup static files from bad Web UI bundle on 2.5.13 release * Check existence first * Esp32 is the only one we care about * Move some actions to after `startTransmit()` (#5383) To minimize the time between channel scan and actual transmit * [create-pull-request] automated change (#5380) Co-authored-by: thebentern <[email protected]> * Allows all 3 PKI keys to be added to userPrefs.h (#4969) and a tool. (#5368) * more userPrefs.h Added PKI Admin keys to userPrefs.h * Update userPrefs.h Allows all 3 PKI keys to be added to userPrefs.h (#4969) * Update NodeDB.cpp Trunk * Update userPrefs.h Changed wording * Create base64_to_hex.py A little tool for converting base64 PKI Keys to decoded byte that userPrefs.h can understand. * more userPrefs.h Added PKI Admin keys to userPrefs.h * Update userPrefs.h Allows all 3 PKI keys to be added to userPrefs.h (#4969) * Update NodeDB.cpp Trunk * Update userPrefs.h Changed wording * Create base64_to_hex.py A little tool for converting base64 PKI Keys to decoded byte that userPrefs.h can understand. * [create-pull-request] automated change (#5388) Co-authored-by: thebentern <[email protected]> * add smiley emoji (#5391) * add smiley emoji * clang-formatted * Anable trace route function on wismeshtap platform (#5389) * fix 'symbal' typo (#5395) * [create-pull-request] automated change (#5399) Co-authored-by: thebentern <[email protected]> * /api/v1/fromradio: add OPTIONS handler for CORS. (#5386) This avoids hitting the 404 Not Found handler, which breaks connection keep-alive, so this change fixes a big performance regression for Web Client in Chrome: #5385 Tested on Heltec V3. Co-authored-by: Ben Meadors <[email protected]> * Make heart emoji usable (#5403) * Create a specific hw_model for WisMesh Tap (#5400) * Create a specific hw_model for WisMesh Tap * Trunk * HAS_ETHERNET * Remove it altogether * Don't need these either * Fix RTC time injection and consolidate position logic (#5396) * Fix RTC time injection and consolidate position logic * Comment out unused var warning * Backerds * Update arduino-pico core to fix sporadic hangs (#5406) * Update platform-raspberrypi also (#5407) * Update arduino-pico core to fix sporadic hangs * Update platform-raspberrypi also * --web added to device-install(.sh/.bat) (#5405) * Add --web * Update device-install.bat Forgot a "-" a few places. --------- Co-authored-by: Ben Meadors <[email protected]> * add GPS in indicator board (#5411) * Fixed NMEA sentence issue in CalTopo as well as bug with no printing all of the nodes (#5412) * --web littlefswebui-* typo fix (#5416) * Add --web * Update device-install.bat Forgot a "-" a few places. * Typo fix. * Typo fix --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: GUVWAF <[email protected]> * Temporarily disable MDNS when MQTT is enabled (#5418) Leads to a panic * Check for OkToMqtt flag presence before uplinking to MQTT (#5413) * Check for oktomqtt flag presence before uplinking to MQTT * Move to mqtt->onSend * Temetry can respond to want-response for LocalStats variant (#5414) * Seems like the last DIY board that's not "extra" (#5420) * Cherry pick tdeck fixes (#5422) * Try-fix (workaround) T-Deck audio crash * set T-Deck audio to unused 48 (mem mclk) * swap mclk to gpio 21 * dreamcatcher: assign GPIO44 to audio mclk --------- Co-authored-by: mverch67 <[email protected]> * add canned message and keyboard in indicator board (#5410) * add canned message and keyboard in indicator board * Added virtual keyboard macro and enabled for Indicator * Cleanup macros by applying USE_VIRTUAL_KEYBOARD and DISPLAY_CLOCK_FRAME --------- Co-authored-by: Ben Meadors <[email protected]> * Update build-native.sh (#5415) * Update build-native.sh Device-install.sh and device-update.sh are not used on native platform, skip copying to release directory after build and copy native-install.sh and native-run.sh instead. * Update build-native.sh Skip native-run.sh copy * Cleans up visibility in GPS.h (#5426) Signed-off-by: Christopher Hoover <[email protected]> * Fix admin key loading from userPrefs.h (#5417) * Fix LED pinout for T-Echo board marked v1.0, date 2021-6-28 * Merge PR #420 * Fixed double and missing Default class. * Use correct format specifier and fixed typo. * Removed duplicate code. * Fix error: #if with no expression * Fix warning: extra tokens at end of #endif directive. * Fix antenna switching logic. Complementary-pin control logic is required on the rp2040-lora board. * Fix deprecated macros. * Set RP2040 in dormant mode when deep sleep is triggered. * Fix array out of bounds read. * Admin key count needs to be set otherwise the key will be zero loaded after reset. * Don't reset the admin key size when loading defaults. Preserve an existing key in config if possible. * Remove log spam when reading INA voltage sensor. * Remove static declaration for admin keys from userPrefs.h. Load hard coded admin keys in case config file has empty slots. * Removed newlines from log. --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Thomas Göttgens <[email protected]> * try to detect dfrobot station to tell it apart from an ublox gps. (#5393) * Remove BMA-423 and STK8X by default (#5429) * Remove BMA-423 by default * STK * Wrong macro * Helps if you include the file * [create-pull-request] automated change (#5431) Co-authored-by: caveman99 <[email protected]> * Support for the ClimateGuard RadSens Geiger-Muller tube (#5425) * fixes #5434 (#5435) * update libpax * fix interval init * Fix memory leaks by adding missing `free()` calls before early returns in `MQTT::onReceive` (#5439) This fix addresses memory leaks in the `MQTT::onReceive` function by ensuring that dynamically allocated resources (`e.channel_id`, `e.gateway_id` and `e.packet`) are properly freed before each early return. Previously, these resources were only freed at the end of the function, leaving them unhandled in certain exit paths. Adding the missing `free()` calls prevents memory leaks and ensures proper resource cleanup in all scenarios. * Removing 1.0 legacy boards from releases and completely removing Heltec wireless capsule from support (#5436) Co-authored-by: Tom Fifield <[email protected]> * A second round of cleanup on GPS.h. (#5433) * Move yet more stuff out of GPS.h and into file scope. * Protect code macros from eating semicolons. * Remove unused (and unimplemented) getDOPString. * clang-format with project style file on affected files. Signed-off-by: Christopher Hoover <[email protected]> * enable MQTT with TLS on RPi picow (#5442) Co-authored-by: Ben Meadors <[email protected]> * Don't powersave on Wifi (#5443) * Don't go into light sleep with wifi enabled * Move * Trunk * Revert "Seems like the last DIY board that's not "extra" (#5420)" (#5446) This reverts commit e6fb6b1. * Actually gunzip all the files when building a .deb (#5449) * [create-pull-request] automated change (#5457) Co-authored-by: thebentern <[email protected]> * Cleanup i2c scan logs and macro to save some bytes and remain consistent (#5455) * Cleanup i2c scan logs and macro to save some bytes and remain consistent * Functions are better than macros * Exclude i2c scan for STM32 * Useless log * Clean up some inline functions (#5454) * Use isWithinTimespanMs to avoid refererence to NodeDb instance inside of NodeDb (#5453) * fix cors for meshtasticd to allow use of cross origin clients (#5463) * Remove ATECC crypto chip placeholder code (#5461) * GPS.h cleanups round 3. (#5447) * GPS.h cleanups round 3. No effective behavior change. Protected members can be private so make it so. (Supporting subclasses needs a lot more work.) Moves uBloxGnssModelInfo into file scope. Moves uBloxProtocolVersion into uBloxGnssModelInfo. Moves baud rate arrays into file scope. Removes unused/ unimplemented powerStateToString. Signed-off-by: Christopher Hoover <[email protected]> * Trunk Format. --------- Signed-off-by: Christopher Hoover <[email protected]> Co-authored-by: Tom Fifield <[email protected]> * Fix ukrainian fonts (#5468) * FIX: rollback to !4624 * UPDATE: new 16 and 24 UA Fonts and fixes * fix: Solve the lightsleep crash problem via disable lightsleep for indicator. (#5470) * Trunk * Warnings and log cleanup (#5472) * Don't log if keyboard not found * Signed comparison issue * [create-pull-request] automated change (#5475) Co-authored-by: thebentern <[email protected]> * Adds libusb dev package to Raspbian build steps (#5480) * [create-pull-request] automated change (#5478) Co-authored-by: thebentern <[email protected]> * Portduino fixes (#5479) * Set config.yaml defaults even if General is missing * Unsigned values should get %u in logging * Update arduino-pico core and remove MDNS restriction (#5483) * Update xiao_esp32 fully support L67K (#5488) L67K module hardware changed * Convert userprefs to a json file instead of header file which has to be included everywhere (#5471) * WIP * Got string quoting and macro expansion working * Need the placeholder * Cleanup * Missed a user prefs reference * Update jsonc * SimRadio: clean-up and emulate collisions (#5487) * Clean up SimRadio and don't let it use PKC * Add collision emulation for SimRadio * Add stats from SimRadio to LocalStats * Make emulating collisions optional * add nodeId to nodeinfo update log lines and removed redundant nodeinfo update log line (#5493) * Refact the macro definition of GPS initialization of GPSDEFAULTD_NOT_PRESENT and added seeeed Indicator to this sequence (#5494) Co-authored-by: Ben Meadors <[email protected]> * Extend Length of Source and Destination Node IDs Logged (#5492) * show 8 chars for logging source and destination ids * extend legnth of source and destination nodes in log * Added femtofox configs (#5477) * added femtofox configs * Rename bin/config.d/femtofox_Waveshare-SX126X-XXXM_AI-Thinker-RA-01SH.yaml to bin/config.d/femtofox/femtofox_Waveshare-SX126X-XXXM_AI-Thinker-RA-01SH.yaml * moved femtofox configs to subdir * [Add] LR1110, LR1120 and LR1121 to linux native Portduino (#5496) * Update main.cpp * Update PortduinoGlue.h * Update PortduinoGlue.cpp * Update PortduinoGlue.cpp * Update PortduinoGlue.cpp * Update main.cpp * [create-pull-request] automated change (#5500) Co-authored-by: thebentern <[email protected]> * Fix minor typos in package workflows (#5505) * Don't use channel index for encrypted packet (#5509) * Don't use channel index for encrypted packet * Remove assert in `getKey`, set invalid key length So encrypting will fail without reboot * Reset channel to 0 when unable to encrypt Such that the NAK doesn't use the failing channel hash * Always Announce MDNS meshtastic service (#5503) * refactor server api port into define * always announce MDNS meshtastic service * fix nodeDB erase loop when free mem returns invalid value (0, -1). (#5519) Co-authored-by: mverch67 <[email protected]> * Add heltec capsule back * Revert "Add heltec capsule back" This reverts commit fc16d93. * Lets try this again minus device ui * Add popular nrf52 pro micro to the builds (#5523) * Add MACAddress to config.yaml (#5506) * Add MACAddress to config.yaml * Better error handling on native, including failing to launch with blank MAC Address and real hardware. * Re-arrange Mac Address handling and add MACAddressSource * Bump portduino to remove macaddr function there --------- Co-authored-by: Ben Meadors <[email protected]> * Configure Seeed Xiao S3 RX enable pin (#5517) * Create OpenWRT_One_mikroBUS_sx1262.yaml (#5529) * tlora_v2_1_16: Unset BUTTON_PIN and BUTTON_NEED_PULLUP (#5535) Unset BUTTON_PIN and BUTTON_NEED_PULLUP as the board ships without a user button. Devices and users expecting a button on GPIO12 have to set [GPIO for user button](https://meshtastic.org/docs/configuration/radio/device/#gpio-for-user-button) to 12 (or any GPIO pin the momentary switch was connected to) to restore functionality. Signed-off-by: Andrew Yong <[email protected]> * [create-pull-request] automated change (#5530) Co-authored-by: thebentern <[email protected]> * Fix detection for some RadSens hardware versions (#5542) Co-authored-by: Jake-B <[email protected]> * Initialize dmac array to nulls (#5538) * Initialize dmac array to nulls * Use std::cout for print before console is init. * Update OpenWRT_One_mikroBUS_sx1262.yaml (#5544) * Add portduino-buildroot variant (#5540) * Add portduino-buildroot variant * Update platform-native for platform-buildroot * portduino-buildroot: Define c standard (#5547) * Portduino: Move meshtasticd/web out of /usr/share/doc/ (#5548) * Portduino: fix transitional symlinks (#5550) * Windows Support - Trunk and Platformio (#5397) (#5518) * Add support for GPG * Add usb device support * Add trunk.io to devcontainer * Trunk things * trunk fmt * formatting * fix trivy/DS002, checkov/CKV_DOCKER_3 * hide docker extension popup * fix trivy/DS026, checkov/CKV_DOCKER_2 Co-authored-by: Kalle Lilja <[email protected]> * Synch minor changes from TFT branch (#5520) * Synch minor changes from TFT branch Includes: * New nordicnrf52 minor version (10.5.0 --> 10.6.0) * Optimisations for T_DECK * preparation for MESH_TAB * add ext notification module to portduino --------- Co-authored-by: mverch67 <[email protected]> * DIO3_TCXO_VOLTAGE in config.yaml can now take an exact voltage (#5558) * Support TLORA_V3.0 (#5563) - Support TLORA_V3.0. Update of the legendary 2.1_1.6.1 with solar charger, TCXO and IPEX connector. - 'extra' some short-lived EOL intermediate boards in that range. If possible use T3S3 instead of all of these! - update trunk to latest version * Create OpenWRT-One-mikroBUS-LR-IOT-CLICK.yaml (#5564) * Portduino: fix setting hwId via argument (#5565) * INA219 charging detection minimal implementation: if there is a configured INA219 sensor for battery monitoring we can take the current flow across the shunt resistor to know if we are charging the battery - negative milliamps indicate charging * Update Power.cpp added comments and 2 extra defines to disable and swap detection direction * Trunk Fixes * Add INA226 support --------- Signed-off-by: Christopher Hoover <[email protected]> Signed-off-by: Andrew Yong <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Jonathan Bennett <[email protected]> Co-authored-by: GUVWAF <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: Michael Gjelsø <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: thebentern <[email protected]> Co-authored-by: jcyrio <[email protected]> Co-authored-by: Daniel.Cao <[email protected]> Co-authored-by: Catalin Patulea <[email protected]> Co-authored-by: dylanli <[email protected]> Co-authored-by: mverch67 <[email protected]> Co-authored-by: madeofstown <[email protected]> Co-authored-by: Christopher Hoover <[email protected]> Co-authored-by: Mictronics <[email protected]> Co-authored-by: Thomas Göttgens <[email protected]> Co-authored-by: caveman99 <[email protected]> Co-authored-by: jake-b <[email protected]> Co-authored-by: César de Tassis Filho <[email protected]> Co-authored-by: Tomas Dubec <[email protected]> Co-authored-by: Liam Cottle <[email protected]> Co-authored-by: panaceya <[email protected]> Co-authored-by: virgil <[email protected]> Co-authored-by: Robert <[email protected]> Co-authored-by: noon92 <[email protected]> Co-authored-by: Mark Trevor Birss <[email protected]> Co-authored-by: broglep <[email protected]> Co-authored-by: Matthias Granberry <[email protected]> Co-authored-by: Andrew Yong <[email protected]> Co-authored-by: Jake-B <[email protected]> Co-authored-by: Austin <[email protected]> Co-authored-by: Kalle Lilja <[email protected]>
1 parent fa1a1fd commit 80fc0f2

11 files changed

+165
-8
lines changed

platformio.ini

+2-1
Original file line numberDiff line numberDiff line change
@@ -160,4 +160,5 @@ lib_deps =
160160
https://github.com/KodinLanewave/[email protected]
161161
162162
163-
https://github.com/meshtastic/DFRobot_LarkWeatherStation#4de3a9cadef0f6a5220a8a906cf9775b02b0040d
163+
https://github.com/meshtastic/DFRobot_LarkWeatherStation#4de3a9cadef0f6a5220a8a906cf9775b02b0040d
164+
robtillaart/[email protected]

src/Power.cpp

+37-2
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,9 @@ static const uint8_t ext_chrg_detect_value = EXT_CHRG_DETECT_VALUE;
7272
#endif
7373

7474
#if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR && !defined(ARCH_PORTDUINO)
75-
INA260Sensor ina260Sensor;
7675
INA219Sensor ina219Sensor;
76+
INA226Sensor ina226Sensor;
77+
INA260Sensor ina260Sensor;
7778
INA3221Sensor ina3221Sensor;
7879
#endif
7980

@@ -413,7 +414,20 @@ class AnalogBatteryLevel : public HasBatteryLevel
413414
#ifdef EXT_CHRG_DETECT
414415
return digitalRead(EXT_CHRG_DETECT) == ext_chrg_detect_value;
415416
#else
417+
#if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR && !defined(ARCH_PORTDUINO) && !defined(ARCH_STM32WL) && \
418+
!defined(DISABLE_INA_CHARGING_DETECTION)
419+
if (hasINA()) {
420+
// get current flow from INA sensor - negative value means power flowing into the battery
421+
// default assuming BATTERY+ <--> INA_VIN+ <--> SHUNT RESISTOR <--> INA_VIN- <--> LOAD
422+
LOG_DEBUG("Using INA on I2C addr 0x%x for charging detection", config.power.device_battery_ina_address);
423+
#if defined(INA_CHARGING_DETECTION_INVERT)
424+
return getINACurrent() > 0;
425+
#else
426+
return getINACurrent() < 0;
427+
#endif
428+
}
416429
return isBatteryConnect() && isVbusIn();
430+
#endif
417431
#endif
418432
}
419433

@@ -450,6 +464,9 @@ class AnalogBatteryLevel : public HasBatteryLevel
450464
{
451465
if (nodeTelemetrySensorsMap[meshtastic_TelemetrySensorType_INA219].first == config.power.device_battery_ina_address) {
452466
return ina219Sensor.getBusVoltageMv();
467+
} else if (nodeTelemetrySensorsMap[meshtastic_TelemetrySensorType_INA226].first ==
468+
config.power.device_battery_ina_address) {
469+
return ina226Sensor.getBusVoltageMv();
453470
} else if (nodeTelemetrySensorsMap[meshtastic_TelemetrySensorType_INA260].first ==
454471
config.power.device_battery_ina_address) {
455472
return ina260Sensor.getBusVoltageMv();
@@ -460,6 +477,20 @@ class AnalogBatteryLevel : public HasBatteryLevel
460477
return 0;
461478
}
462479

480+
int16_t getINACurrent()
481+
{
482+
if (nodeTelemetrySensorsMap[meshtastic_TelemetrySensorType_INA219].first == config.power.device_battery_ina_address) {
483+
return ina219Sensor.getCurrentMa();
484+
} else if (nodeTelemetrySensorsMap[meshtastic_TelemetrySensorType_INA226].first ==
485+
config.power.device_battery_ina_address) {
486+
return ina226Sensor.getCurrentMa();
487+
} else if (nodeTelemetrySensorsMap[meshtastic_TelemetrySensorType_INA3221].first ==
488+
config.power.device_battery_ina_address) {
489+
return ina3221Sensor.getCurrentMa();
490+
}
491+
return 0;
492+
}
493+
463494
bool hasINA()
464495
{
465496
if (!config.power.device_battery_ina_address) {
@@ -469,6 +500,10 @@ class AnalogBatteryLevel : public HasBatteryLevel
469500
if (!ina219Sensor.isInitialized())
470501
return ina219Sensor.runOnce() > 0;
471502
return ina219Sensor.isRunning();
503+
} else if (nodeTelemetrySensorsMap[meshtastic_TelemetrySensorType_INA226].first ==
504+
config.power.device_battery_ina_address) {
505+
if (!ina226Sensor.isInitialized())
506+
return ina226Sensor.runOnce() > 0;
472507
} else if (nodeTelemetrySensorsMap[meshtastic_TelemetrySensorType_INA260].first ==
473508
config.power.device_battery_ina_address) {
474509
if (!ina260Sensor.isInitialized())
@@ -1154,4 +1189,4 @@ bool Power::lipoInit()
11541189
{
11551190
return false;
11561191
}
1157-
#endif
1192+
#endif

src/modules/Telemetry/PowerTelemetry.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ int32_t PowerTelemetryModule::runOnce()
5656
// therefore, we should only enable the sensor loop if measurement is also enabled
5757
if (ina219Sensor.hasSensor() && !ina219Sensor.isInitialized())
5858
result = ina219Sensor.runOnce();
59+
if (ina226Sensor.hasSensor() && !ina226Sensor.isInitialized())
60+
result = ina226Sensor.runOnce();
5961
if (ina260Sensor.hasSensor() && !ina260Sensor.isInitialized())
6062
result = ina260Sensor.runOnce();
6163
if (ina3221Sensor.hasSensor() && !ina3221Sensor.isInitialized())
@@ -170,6 +172,8 @@ bool PowerTelemetryModule::getPowerTelemetry(meshtastic_Telemetry *m)
170172
#if HAS_TELEMETRY && !defined(ARCH_PORTDUINO)
171173
if (ina219Sensor.hasSensor())
172174
valid = ina219Sensor.getMetrics(m);
175+
if (ina226Sensor.hasSensor())
176+
valid = ina226Sensor.getMetrics(m);
173177
if (ina260Sensor.hasSensor())
174178
valid = ina260Sensor.getMetrics(m);
175179
if (ina3221Sensor.hasSensor())
@@ -253,4 +257,4 @@ bool PowerTelemetryModule::sendTelemetry(NodeNum dest, bool phoneOnly)
253257
return false;
254258
}
255259

256-
#endif
260+
#endif
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
#include "configuration.h"
2+
3+
#if !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR
4+
5+
#pragma once
6+
7+
class CurrentSensor
8+
{
9+
public:
10+
virtual int16_t getCurrentMa() = 0;
11+
};
12+
13+
#endif

src/modules/Telemetry/Sensor/INA219Sensor.cpp

+5
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,9 @@ uint16_t INA219Sensor::getBusVoltageMv()
4545
return lround(ina219.getBusVoltage_V() * 1000);
4646
}
4747

48+
int16_t INA219Sensor::getCurrentMa()
49+
{
50+
return lround(ina219.getCurrent_mA());
51+
}
52+
4853
#endif

src/modules/Telemetry/Sensor/INA219Sensor.h

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33
#if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR
44

55
#include "../mesh/generated/meshtastic/telemetry.pb.h"
6+
#include "CurrentSensor.h"
67
#include "TelemetrySensor.h"
78
#include "VoltageSensor.h"
89
#include <Adafruit_INA219.h>
910

10-
class INA219Sensor : public TelemetrySensor, VoltageSensor
11+
class INA219Sensor : public TelemetrySensor, VoltageSensor, CurrentSensor
1112
{
1213
private:
1314
Adafruit_INA219 ina219;
@@ -20,6 +21,7 @@ class INA219Sensor : public TelemetrySensor, VoltageSensor
2021
virtual int32_t runOnce() override;
2122
virtual bool getMetrics(meshtastic_Telemetry *measurement) override;
2223
virtual uint16_t getBusVoltageMv() override;
24+
virtual int16_t getCurrentMa() override;
2325
};
2426

2527
#endif
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
#include "configuration.h"
2+
3+
#if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR
4+
5+
#include "../mesh/generated/meshtastic/telemetry.pb.h"
6+
#include "INA226.h"
7+
#include "INA226Sensor.h"
8+
#include "TelemetrySensor.h"
9+
10+
INA226Sensor::INA226Sensor() : TelemetrySensor(meshtastic_TelemetrySensorType_INA226, "INA226") {}
11+
12+
int32_t INA226Sensor::runOnce()
13+
{
14+
LOG_INFO("Init sensor: %s", sensorName);
15+
if (!hasSensor()) {
16+
return DEFAULT_SENSOR_MINIMUM_WAIT_TIME_BETWEEN_READS;
17+
}
18+
19+
begin(nodeTelemetrySensorsMap[sensorType].second, nodeTelemetrySensorsMap[sensorType].first);
20+
21+
if (!status) {
22+
status = ina226.begin();
23+
}
24+
return initI2CSensor();
25+
}
26+
27+
void INA226Sensor::setup() {}
28+
29+
void INA226Sensor::begin(TwoWire *wire, uint8_t addr)
30+
{
31+
_wire = wire;
32+
_addr = addr;
33+
ina226 = INA226(_addr, _wire);
34+
_wire->begin();
35+
}
36+
37+
bool INA226Sensor::getMetrics(meshtastic_Telemetry *measurement)
38+
{
39+
measurement->variant.environment_metrics.has_voltage = true;
40+
measurement->variant.environment_metrics.has_current = true;
41+
42+
// mV conversion to V
43+
measurement->variant.environment_metrics.voltage = ina226.getBusVoltage() / 1000;
44+
measurement->variant.environment_metrics.current = ina226.getCurrent_mA();
45+
return true;
46+
}
47+
48+
uint16_t INA226Sensor::getBusVoltageMv()
49+
{
50+
return lround(ina226.getBusVoltage());
51+
}
52+
53+
int16_t INA226Sensor::getCurrentMa()
54+
{
55+
return lround(ina226.getCurrent_mA());
56+
}
57+
58+
#endif
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
#include "configuration.h"
2+
3+
#if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR
4+
5+
#include "../mesh/generated/meshtastic/telemetry.pb.h"
6+
#include "CurrentSensor.h"
7+
#include "TelemetrySensor.h"
8+
#include "VoltageSensor.h"
9+
#include <INA226.h>
10+
11+
class INA226Sensor : public TelemetrySensor, VoltageSensor, CurrentSensor
12+
{
13+
private:
14+
uint8_t _addr = INA_ADDR;
15+
TwoWire *_wire = &Wire;
16+
INA226 ina226 = INA226(_addr, _wire);
17+
18+
protected:
19+
virtual void setup() override;
20+
void begin(TwoWire *wire = &Wire, uint8_t addr = INA_ADDR);
21+
22+
public:
23+
INA226Sensor();
24+
virtual int32_t runOnce() override;
25+
virtual bool getMetrics(meshtastic_Telemetry *measurement) override;
26+
virtual uint16_t getBusVoltageMv() override;
27+
virtual int16_t getCurrentMa() override;
28+
};
29+
30+
#endif

src/modules/Telemetry/Sensor/INA3221Sensor.cpp

+5
Original file line numberDiff line numberDiff line change
@@ -102,4 +102,9 @@ uint16_t INA3221Sensor::getBusVoltageMv()
102102
return lround(ina3221.getVoltage(BAT_CH) * 1000);
103103
}
104104

105+
int16_t INA3221Sensor::getCurrentMa()
106+
{
107+
return lround(ina3221.getCurrent(BAT_CH));
108+
}
109+
105110
#endif

src/modules/Telemetry/Sensor/INA3221Sensor.h

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33
#if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR
44

55
#include "../mesh/generated/meshtastic/telemetry.pb.h"
6+
#include "CurrentSensor.h"
67
#include "TelemetrySensor.h"
78
#include "VoltageSensor.h"
89
#include <INA3221.h>
910

10-
class INA3221Sensor : public TelemetrySensor, VoltageSensor
11+
class INA3221Sensor : public TelemetrySensor, VoltageSensor, CurrentSensor
1112
{
1213
private:
1314
INA3221 ina3221 = INA3221(INA3221_ADDR42_SDA);
@@ -35,6 +36,7 @@ class INA3221Sensor : public TelemetrySensor, VoltageSensor
3536
int32_t runOnce() override;
3637
bool getMetrics(meshtastic_Telemetry *measurement) override;
3738
virtual uint16_t getBusVoltageMv() override;
39+
virtual int16_t getCurrentMa() override;
3840
};
3941

4042
struct _INA3221Measurement {

src/power.h

+4-2
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,12 @@ extern RTC_NOINIT_ATTR uint64_t RTC_reg_b;
4242

4343
#if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR && !defined(ARCH_PORTDUINO)
4444
#include "modules/Telemetry/Sensor/INA219Sensor.h"
45+
#include "modules/Telemetry/Sensor/INA226Sensor.h"
4546
#include "modules/Telemetry/Sensor/INA260Sensor.h"
4647
#include "modules/Telemetry/Sensor/INA3221Sensor.h"
47-
extern INA260Sensor ina260Sensor;
4848
extern INA219Sensor ina219Sensor;
49+
extern INA226Sensor ina226Sensor;
50+
extern INA260Sensor ina260Sensor;
4951
extern INA3221Sensor ina3221Sensor;
5052
#endif
5153

@@ -99,4 +101,4 @@ class Power : private concurrency::OSThread
99101
#endif
100102
};
101103

102-
extern Power *power;
104+
extern Power *power;

0 commit comments

Comments
 (0)