Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Field Validation #9

Open
garthvh opened this issue Jan 21, 2024 · 3 comments
Open

Conditional Field Validation #9

garthvh opened this issue Jan 21, 2024 · 3 comments

Comments

@garthvh
Copy link
Member

garthvh commented Jan 21, 2024

Would it be good to have common field validation across platforms so that conflicting settings are not enabled by users?

  • Client proxy and JSON mode can not be enabled at the same time
  • Both phone and Device GPS should not be enabled at the same time.
  • Wifi, MQTT and Client Proxy should not be enabled at the same time
  • Advanced Lora settings should not be visible if use preset is selected
  • Sections with client and sender enabled options (detection sensor, range test, store & forward) should not expose settings not related to that device's role.
@b8b8
Copy link

b8b8 commented Jan 21, 2024

"Both phone and Device GPS should not be enabled at the same time."

Is there not a legitimate use case for this though. If you have higher quality phone GPS use it, but then default back to node GPS automatically. My car node (when i am actively driving around) is bluetoothed to my phone and providing high quality GPS updates to the device. When i am parked or someone else is using my car that doesnt have meshtastic, the device will use the onboard GPS and act as a "tracker" around town.

@garthvh
Copy link
Member Author

garthvh commented Jan 21, 2024

Is there not a legitimate use case for this though. If you have higher quality phone GPS use it, but then default back to node GPS automatically. My car node (when i am actively driving around) is bluetoothed to my phone and providing high quality GPS updates to the device. When i am parked or someone else is using my car that doesnt have meshtastic, the device will use the onboard GPS and act as a "tracker" around town.

Yeah this one is more complicated for sure. Smart position actually works really well, you can prevent blended positions pretty easily and fall back to device gps when the phone disconnects, but all the other modes just blend the data together.

@b8b8
Copy link

b8b8 commented Jan 21, 2024

Blending is good. Just dont want a situation where it sets to phone position, toggles off discrete GPS, then loses phone position and doesnt turn discrete GPS on again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants