propagate labels from tortoise to HPA/VPA managed by tortoise

Signed-off-by: minhthong582000 <[email protected]>

Author: minhthong582000

internal/controller/tortoise_controller.go

@@ -209,6 +209,20 @@ func (r *TortoiseReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_
 		return ctrl.Result{}, err
 	}
 
+	// Update HPA labels to match Tortoise labels
+	err = r.HpaService.UpdateHPALabelsFromTortoise(ctx, tortoise)
+	if err != nil {
+		logger.Error(err, "update HPA labels from Tortoise", "tortoise", req.NamespacedName)
+		return ctrl.Result{}, err
+	}
+
+	// Update VPA labels to match Tortoise labels
+	err = r.VpaService.UpdateVPALabelsFromTortoise(ctx, tortoise)
+	if err != nil {
+		logger.Error(err, "update VPA labels from Tortoise", "tortoise", req.NamespacedName)
+		return ctrl.Result{}, err
+	}
+
 	monitorvpa, ready, err := r.VpaService.GetTortoiseMonitorVPA(ctx, tortoise)
 	if err != nil {
 		logger.Error(err, "failed to get tortoise VPA", "tortoise", req.NamespacedName)

pkg/hpa/service.go

@@ -267,6 +267,8 @@ func (c *Service) CreateHPA(ctx context.Context, tortoise *autoscalingv1beta3.To
 		},
 	}
 
+	c.copyLabelsFromTortoiseToHPA(tortoise, hpa)
+
 	hpa, tortoise, _ = c.syncHPAMetricsWithTortoiseAutoscalingPolicy(ctx, tortoise, hpa, now)
 
 	tortoise.Status.Targets.HorizontalPodAutoscaler = hpa.Name
@@ -275,6 +277,62 @@ func (c *Service) CreateHPA(ctx context.Context, tortoise *autoscalingv1beta3.To
 	return hpa.DeepCopy(), tortoise, err
 }
 
+func (c *Service) copyLabelsFromTortoiseToHPA(tortoise *autoscalingv1beta3.Tortoise, hpa *v2.HorizontalPodAutoscaler) {
+	if len(tortoise.ObjectMeta.Labels) == 0 {
+		return
+	}
+
+	hpa.ObjectMeta.Labels = make(map[string]string, len(tortoise.ObjectMeta.Labels))
+	for k, v := range tortoise.ObjectMeta.Labels {
+		hpa.ObjectMeta.Labels[k] = v
+	}
+}
+
+// UpdateHPA updates HPA labels from Tortoise.
+// Note that it will not perform any update if the UpdateMode is Off, user specified the existing HPA, or there is no horizontal policy.
+func (c *Service) UpdateHPALabelsFromTortoise(ctx context.Context, tortoise *autoscalingv1beta3.Tortoise) error {
+	if tortoise.Spec.UpdateMode == autoscalingv1beta3.UpdateModeOff {
+		// When UpdateMode is Off, we don't update HPA.
+		return nil
+	}
+	if !HasHorizontal(tortoise) {
+		// no need to handle when there is no horizontal policy.
+		return nil
+	}
+	if tortoise.Spec.TargetRefs.HorizontalPodAutoscalerName != nil {
+		// no need to handle when the user specified existing HPA.
+		return nil
+	}
+
+	retryNumber := -1
+	updateFn := func() error {
+		retryNumber++
+		hpa := &v2.HorizontalPodAutoscaler{}
+		if err := c.c.Get(ctx, types.NamespacedName{Namespace: tortoise.Namespace, Name: tortoise.Status.Targets.HorizontalPodAutoscaler}, hpa); err != nil {
+			return fmt.Errorf("failed to get hpa on tortoise: %w", err)
+		}
+		hpa = hpa.DeepCopy()
+
+		if reflect.DeepEqual(hpa.ObjectMeta.Labels, tortoise.ObjectMeta.Labels) {
+			// Labels are already in sync, no need to update.
+			return nil
+		}
+		c.copyLabelsFromTortoiseToHPA(tortoise, hpa)
+
+		if err := c.c.Update(ctx, hpa); err != nil {
+			return fmt.Errorf("failed to update hpa: %w", err)
+		}
+
+		return nil
+	}
+
+	if err := retry.RetryOnConflict(retry.DefaultRetry, updateFn); err != nil {
+		return fmt.Errorf("update hpa labels: %w (%v times retried)", err, retryNumber)
+	}
+
+	return nil
+}
+
 func (c *Service) GetHPAOnTortoiseSpec(ctx context.Context, tortoise *autoscalingv1beta3.Tortoise) (*v2.HorizontalPodAutoscaler, error) {
 	if tortoise.Spec.TargetRefs.HorizontalPodAutoscalerName == nil {
 		return nil, nil