Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset or Clear a Limit #19

Open
patramsey opened this issue Jul 23, 2023 · 7 comments · May be fixed by #90
Open

Reset or Clear a Limit #19

patramsey opened this issue Jul 23, 2023 · 7 comments · May be fixed by #90
Labels
enhancement New feature or request

Comments

@patramsey
Copy link

Hello,

It does not appear that this package allows for the reset of a limit, is that correct? I have come across a use case where rate limits need to be reset. A user forgets their password, gets rate limited logging into their account. They successfully reset their password, the previous limit should be cleared so they are allowed to attempt to login again.

Would you consider a PR for this feature?
@mennanov
Copy link
Owner

I think this is a useful feature, PR would be more than welcomed!

@mennanov
Copy link
Owner

@patramsey would you be interested in creating a pull request with the feature you described? I'd be happy to review and merge it.
Thanks!

@mennanov mennanov added the enhancement New feature or request label Oct 6, 2024
@Madraceee
Copy link

Hey, This looks interesting and I also want to learn this repository. Can I solve this issue or is it already solved?

@mennanov
Copy link
Owner

This is not solved. If you're interested in implementing it please consider making a pull request

Thanks!

@Madraceee
Copy link

I will look into this issue.
If I have any doubts , can I ask them here?

@Madraceee
Copy link

If my understanding is right, For each algo(token Bucket, leaky bucket etc), I need to write another function similar to Limit which resets the state of the backend?

@mennanov
Copy link
Owner

Right. You will also need to add tests for each of them in a similar way it's done for the Limit() method

@Madraceee Madraceee linked a pull request Oct 18, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added Reset to TokenBucket Madraceee/limiters
3 participants
@patramsey @mennanov @Madraceee